Tickets :: Comment on [#1919] SVN Log parsing of Author

* Your Email Address
* Spam protection	Enter the letters below: . ..___ __ . . \|__\|[__ / ` \| \| \| \|[___\__.\__\|\__\|
Comment	> trying to browse some SVN repositories with CHORA will only display > the directories and no the folders. I have tracked this down to the > > lib/Horde/VC/svn.php file. > > > > while trying to parse the svn change log for a file, there seems to > be a slight error in the regular expression around line 730 > > if (preg_match('/^r([0-9]) \\| ([^ ]) \\| (.) $.$ \\| ([0-9]) > lines?$/', $line, $matches)) { > > > > If the author name contains a space this will not work. > > changing the expressio to read: > > > > if (preg_match('/^r([0-9]) \\| (.) \\| (.) $.$ \\| ([0-9]) > lines?$/', $line, $matches)) > > > > will fix the problem. (changed [^ ]* to .* ) > > > > This issue occurs if the repository does not have an Authors name (ie > 'no author') also. > > > > Strange how this has gone so long unchecked..
Attachment
Watch this ticket