Summary | SVN Log parsing of Author |
Queue | Horde Framework Packages |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | |
Requester | shimmanning (at) gmail (dot) com |
Created | 05/05/2005 (7364 days ago) |
Due | |
Updated | 05/06/2005 (7363 days ago) |
Assigned | |
Resolved | 05/06/2005 (7363 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
State ⇒ Unconfirmed
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ SVN Log parsing of Author
Queue ⇒ Horde Framework Packages
the directories and no the folders. I have tracked this down to the
lib/Horde/VC/svn.php file.
while trying to parse the svn change log for a file, there seems to be
a slight error in the regular expression around line 730
if (preg_match('/^r([0-9]*) \| ([^ ]*) \| (.*) \(.*\) \| ([0-9]*)
lines?$/', $line, $matches)) {
If the author name contains a space this will not work.
changing the expressio to read:
if (preg_match('/^r([0-9]*) \| (.*) \| (.*) \(.*\) \| ([0-9]*)
lines?$/', $line, $matches))
will fix the problem. (changed [^ ]* to .* )
This issue occurs if the repository does not have an Authors name (ie
'no author') also.
Strange how this has gone so long unchecked..