Committed, thanks!

Changes have been made in CVS for this ticket:

MFH: Make arguments optional (Bug #8601).
http://cvs.horde.org/diff.php/framework/SessionHandler/Attic/SessionHandler.php?rt=horde&r1=1.13.10.18&r2=1.13.10.19&ty=u
http://cvs.horde.org/diff.php/horde/docs/CHANGES?rt=horde&r1=1.515.2.563&r2=1.515.2.564&ty=u

Changes have been made in Git for this ticket:

Make arguments optional (Bug #8601).

http://git.horde.org/diff.php/framework/SessionHandler/lib/Horde/SessionHandler.php?rt=horde-git&r1=83762b5effdd9bd14e5c84bd2994e49d44fc84ea&r2=cf20e1c1a3d29c41f086d9979cb21553c3cce03e

Using MSSQL as storage for sessions through PEAR's DB abstraction 
layer I found this type of messages in the "current sessions" screen:



Warning: Missing argument 1 for SessionHandler::open(), called in 
/usr/local/share/horde-3.3.5/lib/Horde/SessionHandler/sql.php on line 
307 and defined in 
/usr/local/share/horde-3.3.5/lib/Horde/SessionHandler.php on line 149



Warning: Missing argument 2 for SessionHandler::open(), called in 
/usr/local/share/horde-3.3.5/lib/Horde/SessionHandler/sql.php on line 
307 and defined in 
/usr/local/share/horde-3.3.5/lib/Horde/SessionHandler.php on line 149



Notice: Undefined variable: save_path in 
/usr/local/share/horde-3.3.5/lib/Horde/SessionHandler.php on line 155



Notice: Undefined variable: session_name in 
/usr/local/share/horde-3.3.5/lib/Horde/SessionHandler.php on line 155



These messages are derived from the lack of default null values for 
the arguments of the function open() in lib/Horde/SessionHandler.php 
(or maybe an incorrect use of this function from some other parts of 
the code).



In any case makes sense for me to apply this:



--- horde-3.3.5.orig/lib/Horde/SessionHandler.php       2009-09-23 
17:59:12.206783858 +0200

+++ horde-3.3.5/lib/Horde/SessionHandler.php    2009-09-23 
18:16:05.402784153 +0200

@@ -146,7 +146,7 @@

       *

       * @return boolean  True on success, false otherwise.

       */

-    function open($save_path, $session_name)

+    function open($save_path = null, $session_name = null)

      {

          if ($this->_connected) {

              return true;



See trivial patch attached.