Summary | Full HTML/CSS support on message view |
Queue | IMP |
Queue Version | Git master |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | rui.carneiro (at) portugalmail (dot) net |
Created | 09/22/2009 (5762 days ago) |
Due | |
Updated | 01/13/2010 (5649 days ago) |
Assigned | |
Resolved | 09/28/2009 (5756 days ago) |
Milestone | |
Patch | Yes |
Ticket #8592: Fix resizing heighthttp://git.horde.org/diff.php/imp/js/imp.js?rt=horde-git&r1=c1716b393f3d2656419610100aeb8e9d4a6b6670&r2=e41030bfb7f3603f8a631615ebc5655788e0d0d8
Ticket #8592- More IFRAME/HTML workIFRAME & IFRAME data are now loaded on the same page; javascript does
the dynamic addition of the text to the IFRAME. Saves a server access.
Image block display now works again entirely via javascript, rather than
requiring another server access.
http://git.horde.org/diff.php/imp/js/imp.js?rt=horde-git&r1=f1f00322567d2ebed6e2b6cf61b03ed603f28940&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/lib/Contents.php?rt=horde-git&r1=df76454c4d762ea3e0b23bc6e84c1328b2965d90&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/lib/Mime/Viewer/Html.php?rt=horde-git&r1=1a57ad3e16e1a3e92b0f087ba1765c9089c48577&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/lib/Views/ShowMessage.php?rt=horde-git&r1=824a98c46d190c69bd5fd416cc7c8f9c448c12f4&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/message-dimp.php?rt=horde-git&r1=f0daa2470ea069c3488276d2ecb1f92c6fdc86b3&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/message.php?rt=horde-git&r1=fc6151a2aeac321c8fd30db7b81ea9e4686c0d39&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/themes/screen.css?rt=horde-git&r1=5229eff83fdc1e80083c65e2a5f818b524218943&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
Ticket #8592: First attempt at displaying HTML parts in IFRAMEshttp://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-git&r1=d843b290d5ec78fe4c3e956915d7722cceb79314&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
http://git.horde.org/diff.php/imp/js/imp.js?rt=horde-git&r1=400112e6564dfcbea2f6186698cb4217708af30e&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
http://git.horde.org/diff.php/imp/lib/Mime/Viewer/Html.php?rt=horde-git&r1=df76454c4d762ea3e0b23bc6e84c1328b2965d90&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
http://git.horde.org/diff.php/imp/themes/screen.css?rt=horde-git&r1=6280034edd359c1714da66c47ddba497f0215726&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
requiring another server access.
reviewed to remove CSS images too? (e.g. list-style-image,
background-image)
State ⇒ Resolved
(http://www.email-standards.org/acid/). Resolving ticket.
We should only be matching url:script inside of HTML tags
Ticket #8592http://git.horde.org/diff.php/framework/Text_Filter/lib/Horde/Text/Filter/Xss.php?rt=horde-git&r1=a4821dba3cebdd907a36635ce22b9569ce35e32b&r2=fbcb1010297ccde83dd1b33194eeaf8fddd364a9
probably all previous versions). Probably is some issue with
javascript and iframes. Handling iframes on IE is pretty different
from all other browsers. Maybe I missed something.
IFRAME HTML code. This is irrelevant now, as we now use a different
method to perform onload actions.
Additionally, the Horde HTML driver was stripping style attributes for
all IE versions. This has been corrected.
Ticket #8592: Fix resizing heighthttp://git.horde.org/diff.php/imp/js/imp.js?rt=horde-hatchery&r1=c1716b393f3d2656419610100aeb8e9d4a6b6670&r2=e41030bfb7f3603f8a631615ebc5655788e0d0d8
Ticket #8592- More IFRAME/HTML workIFRAME & IFRAME data are now loaded on the same page; javascript does
the dynamic addition of the text to the IFRAME. Saves a server access.
Image block display now works again entirely via javascript, rather than
requiring another server access.
http://git.horde.org/diff.php/imp/js/imp.js?rt=horde-hatchery&r1=f1f00322567d2ebed6e2b6cf61b03ed603f28940&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/lib/Contents.php?rt=horde-hatchery&r1=df76454c4d762ea3e0b23bc6e84c1328b2965d90&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/lib/Mime/Viewer/Html.php?rt=horde-hatchery&r1=1a57ad3e16e1a3e92b0f087ba1765c9089c48577&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/lib/Views/ShowMessage.php?rt=horde-hatchery&r1=824a98c46d190c69bd5fd416cc7c8f9c448c12f4&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/message-dimp.php?rt=horde-hatchery&r1=f0daa2470ea069c3488276d2ecb1f92c6fdc86b3&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/message.php?rt=horde-hatchery&r1=fc6151a2aeac321c8fd30db7b81ea9e4686c0d39&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
http://git.horde.org/diff.php/imp/themes/screen.css?rt=horde-hatchery&r1=5229eff83fdc1e80083c65e2a5f818b524218943&r2=c1716b393f3d2656419610100aeb8e9d4a6b6670
probably all previous versions). Probably is some issue with
javascript and iframes. Handling iframes on IE is pretty different
from all other browsers. Maybe I missed something.
renderNoImages()/IMP_Contents::/view.php is entirely unnecessary.
There is already the appropriate code in view.php to allow us to
determine what view we want (the 'mode' parameter), and we pass what
state we need via URL parameters (e.g. 'html_iframe_data').
require a separate request to load the HTML data (and to display
images).
non-javascript enabled browsers because trying
to maintain a separate filtering regime vs. IFRAME content probably
isn't worth it for the minimal browsers lacking javascript support.
New Attachment: Heiße News_ Grillen auf dem iPhone.eml
viewing HTML inline on non-javascript enabled browsers because trying
to maintain a separate filtering regime vs. IFRAME content probably
isn't worth it for the minimal browsers lacking javascript support.
Attached is a HTML message where the IFRAME resizing doesn't work at all.
Assigned to Michael Slusarz
State ⇒ Accepted
renderNoImages()/IMP_Contents::/view.php is entirely unnecessary.
There is already the appropriate code in view.php to allow us to
determine what view we want (the 'mode' parameter), and we pass what
state we need via URL parameters (e.g. 'html_iframe_data').
I haven't implemented any of the fancier 'loading' graphics yet.
Still need to work out some details - namely, it would be nice to not
require a separate request to load the HTML data (and to display
images). There are issues with IFRAME/same source restrictions that
can be worked around with javascript, but it remains to be seen if it
is viable in the IMP framework. Additionally, IFRAMEs simply will not
work without javascript (there is no way to correctly size an IFRAME
without javascript). My inclination is simply to prohibit viewing
HTML inline on non-javascript enabled browsers because trying to
maintain a separate filtering regime vs. IFRAME content probably isn't
worth it for the minimal browsers lacking javascript support.
Ticket #8592: First attempt at displaying HTML parts in IFRAMEshttp://git.horde.org/diff.php/imp/docs/CHANGES?rt=horde-hatchery&r1=d843b290d5ec78fe4c3e956915d7722cceb79314&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
http://git.horde.org/diff.php/imp/js/imp.js?rt=horde-hatchery&r1=400112e6564dfcbea2f6186698cb4217708af30e&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
http://git.horde.org/diff.php/imp/lib/Mime/Viewer/Html.php?rt=horde-hatchery&r1=df76454c4d762ea3e0b23bc6e84c1328b2965d90&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
http://git.horde.org/diff.php/imp/themes/screen.css?rt=horde-hatchery&r1=6280034edd359c1714da66c47ddba497f0215726&r2=f1f00322567d2ebed6e2b6cf61b03ed603f28940
State ⇒ New
New Attachment: html_support.zip
Patch ⇒ Yes
Milestone ⇒
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Full HTML/CSS support on message view
Queue ⇒ IMP
HTML/CSS is striped to ensure that webmail's design is not affected by
any code inside a message.
Because that some messages do not respect HTML/CSS standards. The
objective of this enhancement is to develop full support for HTML/CSS
on IMP. The final goal is to pass on Email Standards:
http://www.email-standards.org/
Note: the diff on Xss.php is just to avoid this unclosed bug:
http://bugs.horde.org/ticket/8581