Summary | synml broken because of tasklist required on update |
Queue | Nag |
Queue Version | 2.3.1 |
Type | Enhancement |
State | Duplicate |
Priority | 2. Medium |
Owners | |
Requester | michael-dev (at) fami-braun (dot) de |
Created | 04/09/2009 (5933 days ago) |
Due | |
Updated | 09/06/2017 (2861 days ago) |
Assigned | |
Resolved | 04/10/2009 (5932 days ago) |
Milestone | |
Patch | Yes |
commit 64efc1c96a35d565b5302202f93026af5a4b93bb
Author: Moritz Venn <ritzmo@php.net>
Date: Tue Jul 11 08:13:09 2006 +0000
Follow Mediawiki markup standards with single newlines (#8174,
thanks Brian Sipos)
git-svn-id:
https://svn.php.net/repository/pear/packages/Text_Wiki/trunk@216126
c90b9560-bf6c-de11-be94-00142212c4b1
Text/Wiki/Parse/Mediawiki/Break.php | 70 +++++++++++++++++++++++++++++++
Text/Wiki/Parse/Mediawiki/Newline.php | 77
+++++++++++++++++++++++++++++++++++
2 files changed, 147 insertions(+)
http://github.com/horde/horde/commit/64efc1c96a35d565b5302202f93026af5a4b93bb
State ⇒ Duplicate
#8175Priority ⇒ 2. Medium
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Nag
Summary ⇒ synml broken because of tasklist required on update
Type ⇒ Enhancement
State ⇒ New
client, this failes because it is tried to update a tasklist of an
existing task to NULL.
In /usr/share/horde/horde/nag/lib/Driver.php on line 345 an error
occurs because $share is a PEAR_ERROR. This is not properly caught.
The solution is to change line 322 to look like
if ($task->tasklist != $tasklist && $tasklist != null) {
. This prevents setting a tasklist to NULL. Calling modify with
tasklist=NULL looks valid to me, because the parameter is declared
optional.