Summary | Password expiration for Sun/Fedora Directory Server |
Queue | Horde Framework Packages |
Queue Version | HEAD |
Type | Enhancement |
State | Resolved |
Priority | 1. Low |
Owners | chuck (at) horde (dot) org |
Requester | marco (at) csita (dot) unige (dot) it |
Created | 12/15/2007 (6415 days ago) |
Due | |
Updated | 12/20/2007 (6410 days ago) |
Assigned | |
Resolved | 12/20/2007 (6410 days ago) |
Milestone | |
Patch | No |
Assigned to Chuck Hagenbuch
State ⇒ Resolved
Horde 3.2.0). Thanks!
New Attachment: ldap.php[1].patch
those attributes don't exist?
which are not recognized, they are ignored by the server."
However, I test the code with OpenLDAP and Fedora DS without trouble.
potential fault is being protected against, the comment should
indicate that. Should it really be a login failure if there's bad
data in this field?
format is a serious trouble.
But final user don't care about it. Instead of raising an error, I log
a message.
- it's much faster. If you could take a quick read through
horde/docs/CODING_STANDARDS that would be wonderful, for this or
future contributions, but I can fix this patch (whitespace mostly) as
it's small.
those attributes don't exist?
Please avoid code for "shouldn't happen" situations. If a specific
potential fault is being protected against, the comment should
indicate that. Should it really be a login failure if there's bad data
in this field?
Also, please use pcre (preg_match) instead of ereg in all Horde code -
it's much faster. If you could take a quick read through
horde/docs/CODING_STANDARDS that would be wonderful, for this or
future contributions, but I can fix this patch (whitespace mostly) as
it's small.
New Attachment: ldap.php.patch
I've some trouble in matching my system with your bugtrak service...
The right patch is this and it is for lib/Horde/Auth/ldap.php, not for
the password changer driver.
State ⇒ Feedback
regular one?
Priority ⇒ 1. Low
State ⇒ New
New Attachment: smbldap.php.patch
Queue ⇒ Horde Framework Packages
Summary ⇒ Password expiration for Sun/Fedora Directory Server
Type ⇒ Enhancement
to record password expiration date.
I submit a patch to use this attribute to warn the user about password
expiration.
This solution is not perfect, because:
- password policy shoul be read from LDAP server instead of Horde
configuration
- Fedora/Sun Directory Server provide a grace period in which you can
authenticate after expiration; in this time your messages present a
negative number of remaining days.
Cheers,
Marco.