6.0.0-beta1
10/16/25

[#5956] Global whitelist spamassassin accidental deletion via imp.
Summary Global whitelist spamassassin accidental deletion via imp.
Queue Sam
Queue Version HEAD
Type Bug
State Not A Bug
Priority 2. Medium
Owners
Requester gimili17 (at) gmail (dot) com
Created 12/04/2007 (6526 days ago)
Due
Updated 12/13/2007 (6517 days ago)
Assigned 12/04/2007 (6526 days ago)
Resolved 12/09/2007 (6521 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
12/13/2007 01:07:04 PM gimili17 (at) gmail (dot) com Comment #7 Reply to this comment
No further comments Chuck?



Am I wrong?  I think a user uses the global whitelist regardless if 
they have their own whitelist?  You don't think hiding the global 
whitelist without warning for an admin user when he adds one more 
entry from imp (thus making accidental deletion very easy) is not a 
bug?  Thanks.
12/09/2007 01:52:38 AM gimili17 (at) gmail (dot) com Comment #6 Reply to this comment
I think I finally understand what's going on here. The global
defaults are *just* defaults. If a user has one whitelist address,
then they will use *only* their own whitelist, not the global
defaults you have saved.
Hmm...I don't think that is true and to me that does not make sense.   
To me when an email is whitelisted under global it applies to everyone 
whether or not they have there own personal list.  I just did a test.   
I added my gmail address to the global whitelist under an admin user.   
I logged in under a test user.  I addded a dummy email on their 
whitelist.  Then I sent them an email from my gmail account and the 
email header reads:  X-Spam-Status: No, score=-97.3 required=3.7 
tests=AWL,SPF_NEUTRAL,

        USER_IN_WHITELIST autolearn=no version=3.2.3



Therefore global list is still being used?  Maybe someone else could 
verify in case I flubbed something.  It only takes a few minutes.
When you whitelisted an address from IMP, that went into your
whitelist, not the global one. Thereafter you saw just that one
address. The globals were still there and you probably would have
seen them if you deleted the one address. But when you made that one
address global, then yes, you deleted the existing globals.
IMHO:  There should be a warning message saying that "rather than 
adding one more email to global you are deleting all your existing 
whitelist."  Sometimes this whitelist is long and has taken a number 
of years to fine tune.



If they were defaults for each user why do they get deleted when you 
add one more entry to the whitelist from imp without at least a warning?



Maybe there should be a button the that says "Show me the globals" if 
they can be so easily inadvertently hidden or at at least a note 
explain what happened.
So there's no bug here, just a misunderstanding about the global
list. I suggest that you use a separate user account to maintain the
global defaults, given how you want it to behave.
Sure seems like funny behavior if not a bug.  Beside the button it 
says "Make settings Global" not "Make these defaults".  I agree that 
using a separate account to maintain the globals helps but you 
shouldn't have to do that.  What happens if you have a system wide 
junk folder that you want to scan with imp and flag a bunch of 
messages and then hit whitelist?  You would think that clicking 
whitelist under imp wouldn't cause you to lose the visibility of the 
global whitelist.  With the current setup one can easily inadvertently 
delete a whitelist of important contacts as I recently did and then 
get angry calls when emails from important contacts (that you were 
told to whitlist) are found in the spam folders.  ** Thank you very 
kindly for your help working through this. **
12/09/2007 12:03:27 AM Chuck Hagenbuch Comment #5
State ⇒ Not A Bug
Reply to this comment
I think I finally understand what's going on here. The global defaults 
are *just* defaults. If a user has one whitelist address, then they 
will use *only* their own whitelist, not the global defaults you have 
saved.



When you whitelisted an address from IMP, that went into your 
whitelist, not the global one. Thereafter you saw just that one 
address. The globals were still there and you probably would have seen 
them if you deleted the one address. But when you made that one 
address global, then yes, you deleted the existing globals.



So there's no bug here, just a misunderstanding about the global list. 
I suggest that you use a separate user account to maintain the global 
defaults, given how you want it to behave.
12/05/2007 01:53:57 AM gimili17 (at) gmail (dot) com Comment #4 Reply to this comment
Why was this in the IMP queue?
Probably my mistake.  I am not an expert.  I figured it should go in 
Imp or Sam.



And if you are really using Sam with
the spamd_sql driver, whitelists are stored one at a time in the db -
there is no threshhold that would push them over the limit.
I don't think a threshhold is the problem.  I think it has to do with 
the global whitelist and the user's whitelist in the same field on the 
form and the tick box for global.  I wondered if it something to do 
with mysql not allowing duplicates for the user and for global.



I just tried it again.  I added 3 global email addresses.  I went to 
imp and whitelisted one more and now the 3 global ones are gone from 
the list in sam.  If I hit save global again they are removed from the 
global whitelist.  Maybe someone else could try this to see if they 
get the same result.  Perhaps I am doing something wrong.  I use 
Microsoft Access with tables linked to mysql to double check what is 
going on.  At a minimum it seems like a very easy way to accidentally 
delete your global whitelist without any warning.
If you're using something with a prefs backend, like Ingo's IMAP
client-side filters, then it seems like you haven't set
$conf['prefs']['maxsize'] appropriately.
I don't think I am.  Do you mean by this that I have too many in the 
whitelist?  I don't think this is an issue as I just tried it with 3 
emails and it did the same thing as with 30.  Thank you.
12/04/2007 05:17:09 AM Chuck Hagenbuch Comment #3
State ⇒ Feedback
Queue ⇒ Sam
Version ⇒ HEAD
Reply to this comment
Why was this in the IMP queue? And if you are really using Sam with 
the spamd_sql driver, whitelists are stored one at a time in the db - 
there is no threshhold that would push them over the limit.



If you're using something with a prefs backend, like Ingo's IMAP 
client-side filters, then it seems like you haven't set 
$conf['prefs']['maxsize'] appropriately.
12/04/2007 01:15:17 AM gimili17 (at) gmail (dot) com Comment #2 Reply to this comment
I also tried typing in one more email by hand in sam and it did the 
same thing. When I hit save all the ones that were already global got 
erased leaving only the one I just typed. The ones that are not 
already global don't get erased. Then if I hit global and save I am 
only left with the one email I just typed as global.
12/04/2007 01:07:24 AM gimili17 (at) gmail (dot) com Comment #1
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Global whitelist spamassassin accidental deletion via imp.
Queue ⇒ IMP
State ⇒ Unconfirmed
Reply to this comment
I have a long list for global whitelist in spamassassin stored in 
mysql (entered via sam).  All works perfectly.  I paste a long list 
into whitelist in sam then save.  One day they all disappear.  When I 
am in imp and whitelist one more email address it erases all of the 
global whitelists for my user name as they are already global and it 
would be duplication.  This makes sense but now when I click the "Make 
Settings Global" and hit save in sam not only is the list gone for my 
user name they are also deleted for global.  Now I get nasty calls 
saying why are important people ending up in junk folder.  Perhaps 
global whitelist should be in a separate spot?

Saved Queries