6.0.0-git
2019-05-23

[#5912] set start and stop times for maildrop vacation recipes
Summary set start and stop times for maildrop vacation recipes
Queue Ingo
Queue Version HEAD
Type Enhancement
State No Feedback
Priority 1. Low
Owners
Requester steinkel (at) ctinetworks (dot) com
Created 2007-11-21 (4201 days ago)
Due
Updated 2008-04-16 (4054 days ago)
Assigned
Resolved 2008-04-16 (4054 days ago)
Milestone
Patch No

History
2008-04-16 18:02:44 Chuck Hagenbuch State ⇒ No Feedback
 
2008-02-24 12:34:57 Jan Schneider Comment #11 Reply to this comment
Ping?
2007-12-07 14:52:30 Jan Schneider Comment #10 Reply to this comment
What does the extra trimming of the email addresses do and why?
The extra trims in the foreach loop are from paranoia about too many
exploits using embedded control characters in mail headers.
Shouldn't this rather be done through addcslashes() like anywhere else 
in the maildrop driver?
What's about the currently outcommented ignorelist stuff a few lines
above? Can this go now?
I redid the ignorelist regex to simplify it for debugging my code.
It can certainly be bulked-up, but I think the original ignorelist is
not workable in its current form.  I am using it now as it sits.
I consider this as a "yes."
2007-12-03 18:38:52 steinkel (at) ctinetworks (dot) com Comment #9 Reply to this comment
What does the extra trimming of the email addresses do and why?
The extra trims in the foreach loop are from paranoia about too many 
exploits using embedded control characters in mail headers.
What's about the currently outcommented ignorelist stuff a few lines
above? Can this go now?
I redid the ignorelist regex to simplify it for debugging my code.  It 
can certainly be bulked-up, but I think the original ignorelist is not 
workable in its current form.  I am using it now as it sits.
2007-12-03 17:52:22 Jan Schneider Comment #8 Reply to this comment
What does the extra trimming of the email addresses do and why?

What's about the currently outcommented ignorelist stuff a few lines 
above? Can this go now?
2007-11-28 17:46:22 Chuck Hagenbuch Deleted Original Message
 
2007-11-26 15:36:23 steinkel (at) ctinetworks (dot) com Comment #7
New Attachment: maildrop.vacation.diff Download
Reply to this comment
Here is the latest diff, including start and end times, 
list/bulk/junk/admin mail ignoring, and excluded addresses.  I 
simplified the admin mail regexp for debugging purposes.
2007-11-21 23:39:21 Jan Schneider Comment #6
State ⇒ Feedback
Reply to this comment
please move the "current_time=time" line before the vacation
start/end time checks
Please provide an updated patch.
2007-11-21 23:38:29 Jan Schneider Deleted Original Message
 
2007-11-21 20:02:19 steinkel (at) ctinetworks (dot) com Comment #5 Reply to this comment
After you have rendered judgement on these, I have suggestions for 
handling exclusions as well
2007-11-21 19:44:25 steinkel (at) ctinetworks (dot) com Comment #4 Reply to this comment
please move the "current_time=time" line before the vacation start/end 
time checks
2007-11-21 18:36:06 steinkel (at) ctinetworks (dot) com Comment #3
New Attachment: updated.vacation.diff
Reply to this comment
Here is the latest diff against CVS HEAD, including 'ignorelist' checking.



In the future, I will do more testing before posting.
2007-11-21 17:40:41 steinkel (at) ctinetworks (dot) com Comment #2 Reply to this comment
This has been lightly tested.
Heavier testing led to the addition to an else clause at the end, so 
the generated reply is not delivered to the local mailbox



=== add after line 518 ===

             $this->_action[] = '  else';

             $this->_action[] = '  {';

             $this->_action[] = '    to "/dev/null";';

             $this->_action[] = '  }';
2007-11-21 16:41:27 steinkel (at) ctinetworks (dot) com Comment #1
Type ⇒ Enhancement
State ⇒ New
Priority ⇒ 1. Low
Summary ⇒ set start and stop times for maildrop vacation recipes
Queue ⇒ Ingo
New Attachment: vacation.diff
Reply to this comment
This has been lightly tested.

Saved Queries