6.0.0-beta1
7/10/25

[#5901] Vacation filter - save and enable
Summary Vacation filter - save and enable
Queue Ingo
Queue Version HEAD
Type Bug
State No Feedback
Priority 2. Medium
Owners
Requester dgehl (at) inverse (dot) ca
Created 11/19/2007 (6443 days ago)
Due
Updated 01/16/2008 (6385 days ago)
Assigned 11/19/2007 (6443 days ago)
Resolved 01/16/2008 (6385 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
01/16/2008 10:43:23 PM Jan Schneider State ⇒ No Feedback
 
01/07/2008 12:48:33 PM Jan Schneider Comment #10 Reply to this comment
Hello?
12/18/2007 06:48:05 PM Jan Schneider Comment #9 Reply to this comment
The duplicate reference is actually bug 4370.
12/18/2007 06:45:45 PM Jan Schneider Comment #8 Reply to this comment
Can you please try if the attached patch fixes this for you?
12/18/2007 06:45:20 PM Jan Schneider New Attachment: ingo_storage.diff Download
 
12/07/2007 06:06:12 PM Jan Schneider Comment #7 Reply to this comment
I tried with both PHP 4.4 and PHP 5.2 by the way.
12/07/2007 06:05:45 PM Jan Schneider Comment #6 Reply to this comment
I still can't reproduce this. And it's probably a duplicate of bug #5901.
12/04/2007 12:49:27 PM dgehl (at) inverse (dot) ca Comment #5 Reply to this comment
Have you tried changing multiple preferences in a regular Options
screen and seeing if both are saved?
Regular options (apart from the filters) work fine


12/04/2007 05:54:48 AM Chuck Hagenbuch Comment #4 Reply to this comment
Have you tried changing multiple preferences in a regular Options 
screen and seeing if both are saved?



To Jan or another developer: seems like with all of the 
Prefs::singleton() calls it's possible something is getting mixed up 
with shutdown functions. If that's the case I wonder if skipping the 
singleton in _retrieve() and _store() and just doing factory - and 
maybe adding an explicit store() call, since it is a store method - 
and then unset($prefs), might help.



I don't have the backends set up to test this right now.
12/03/2007 05:32:20 PM dgehl (at) inverse (dot) ca Comment #3 Reply to this comment
What Horde version are you using? Are you up-to-date with Ingo HEAD
or is it an old version? What prefs backend are you using?
Horde version is 3.2 cvs, Ingo is CVS checkout and the prefs backend 
is a postgresql database using the sql driver
11/19/2007 07:58:43 PM Chuck Hagenbuch Comment #2
State ⇒ Feedback
Reply to this comment
What Horde version are you using? Are you up-to-date with Ingo HEAD or 
is it an old version? What prefs backend are you using?
11/19/2007 03:01:02 PM dgehl (at) inverse (dot) ca Comment #1
Priority ⇒ 2. Medium
State ⇒ Unconfirmed
Queue ⇒ Ingo
Summary ⇒ Vacation filter - save and enable
Type ⇒ Bug
Reply to this comment
Ingo is configured with the preferences backend:



How to reproduce the problem:

- click on filters

- click on vacation

- change the subject or the test

- click on "save and enable"



Result:

- new message is in place in sieve

- no change has been made in the vacation preference in the 
preferences postgres database backend



If I click only on 'Save' instead of 'Save and Enabled', the script is 
saved correctly.





The problem leading to the bug is that when I click 'Save and Enable',

first the 'vacation' preference is set, then the 'filter' preference (to

enable the vacation message). Unfortunately, when the preference 
'store' method is

executed, only the 'filter' preference is saved, but not the 'vacation' one.



The problem can be circumvented by adding an explicit preferences 
'store' call at the end of the _store method in lib/Storage/prefs.php 
as follows:

$prefs->store();


Saved Queries