A test exists in framework/Util/test/addParameter.phpt.

Another example is the initial url generation in IMP::getInitialUrl() 
when not using cookies. It's double encoding ampersands even though it 
is told not to, logging the user immediately out.

The question is, did the change fix more problems than it produced. 
This might not have been working reliably in the past, but we are now 
getting more complaints then before. And we can probably work around 
the old behaviour which is better than fixing all those places where 
it's broken now.

But this was precisely the issue that was fixed.  The previous code 
did not (and could not) reliably detect these ampersands - 
particularly with URLs that get passed between pages via forms (this 
was the reason for the fix in the first place).  This is an example 
(IMHO) of a necessary BC break to fix a larger problem elsewhere.

No, it used to automatically detect whether existing ampersands are 
already encoded in the URL or not. This is a BC break.

How is this a bug?  You are asking Util::addParameter() to encode the 
ampersands in your URL, and that is what it is doing.

The  Horde_Form::addParameter add some extra characters to the URL 
when it is generated.

Steps to reproduce:

Define a class inherited from Horde_Form and instantiate the class. 
Add the parameters like this:

$form = &new EmpDocument_Form($variables, "Add Documents")

$renderer = &$form->getRenderer();

$main_url = Horde::applicationUrl('editemployee.php');

$edit_url = Util::addParameter($main_url, array('action' => 'add_doc', 
'emp_id'=> $emp_id));

$form->renderActive($renderer, $variables, $edit_url, 'post');



But  when the HTML form is generated it adds some extra characters 
like "amp;" to the URL. Here is the complete URL copied from the "View 
Source" of the browser.



Browser: Firefox-2.0

PHP-5.1.4

Horde-3.2CVS