Summary | patch for maintenance |
Queue | Horde Framework Packages |
Queue Version | HEAD |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | vilius (at) lnk (dot) lt |
Created | 11/01/2006 (6828 days ago) |
Due | |
Updated | 11/03/2006 (6826 days ago) |
Assigned | 11/03/2006 (6826 days ago) |
Resolved | 11/03/2006 (6826 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Feedback
redirect URL is something like:
foo.php?foo1=bar1&app=imp
Then we add another parameter via addParameter() so the redirect URL
looks like this:
foo.php?foo1=bar1&app=imp&foo2=bar2
So we are mixing and matching & and & because addParameter()
doesn't recognize we are already using & in the query string. And
we can't encode all &'s as &'s, as your patch does, since this
won't work with the Redirect calls in some browsers.
So what I have done is rewritten addParameter() to auto detect the
current delimiter and deal with it in a consistent manner. So
feedback on this change is needed to see if that fixes this issue.
Assigned to Michael Slusarz
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ patch for maintenance
Queue ⇒ Horde Framework Packages
New Attachment: maintenance.patch
State ⇒ Unconfirmed
maintenance don't work if "What application should Horde display after
login? " preference was set to IMP. It seems that in this case action
url in maintenance form was encoded twice. However this does not
happen when application after login is set to something different, for
example to Horde.
I don't know if I did it the correct way, but this patch works for me
in both cases.
BTW, might solve
bug 2910too.