Tickets :: [#4307] Permissions Window - Save and Close

6.0.0-beta4

3/13/26

Summary	Permissions Window - Save and Close
Queue	Horde Framework Packages
Queue Version	FRAMEWORK_3
Type	Enhancement
State	Resolved
Priority	1. Low
Owners
Requester	webmgr (at) muskingum (dot) edu
Created	08/17/2006 (7148 days ago)
Due
Updated	11/21/2006 (7052 days ago)
Assigned
Resolved	11/21/2006 (7052 days ago)
Milestone
Patch	No

11/21/2006 01:12:32 AM	Chuck Hagenbuch	Comment #7 State ⇒ Resolved	Reply to this comment
Added to HEAD and FW_3.

08/21/2006 01:09:52 AM	webmgr (at) muskingum (dot) edu	Comment #6	Reply to this comment
I thought about that too initially, but that would mean opening the window again and again if you want to add more than one user/group. As did I, and that's why I opted to have both.

08/20/2006 08:24:28 PM	Chuck Hagenbuch	Comment #5 State ⇒ Accepted	Reply to this comment
True.

08/19/2006 08:34:53 AM	Jan Schneider	Comment #4	Reply to this comment
I thought about that too initially, but that would mean opening the window again and again if you want to add more than one user/group.

08/19/2006 03:35:35 AM	Chuck Hagenbuch	Comment #3 State ⇒ Feedback	Reply to this comment
Do we just want to make closing the window the default?

08/17/2006 06:51:46 PM	webmgr (at) muskingum (dot) edu	Comment #2	Reply to this comment
Slight correction It should appear directly between these two lines: $share->setPermission($perm, false); $share->save(); ---> Here

08/17/2006 04:12:02 PM	webmgr (at) muskingum (dot) edu	Comment #1 Priority ⇒ 1. Low Type ⇒ Enhancement Summary ⇒ Permissions Window - Save and Close Queue ⇒ Horde Framework Packages State ⇒ New	Reply to this comment
Borrowing the code from the Save and Finish button on the Kronolith 2.1.2 Attendees page, I have added a Save and Finish button on the Permissions dialog as well. I apologize, I have no idea (but would love to learn) how to work with the patch files, so I will just post my code changes as follows: In "services/shares/edit.php" go to line 229 and add: if (Util::getFormData('addNewClose')) { Util::closeWindowJS(); exit; } It should appear directly between these two lines: $share->setPermission($perm, false); ---> Here $share->save(); In "templates/shares/edit.inc go to Line 217 where it should say: <input type="submit" class="button" value="<?php printf(_("Save %s"), htmlspecialchars($share->get('name'))) ?>" /> Add the following code immediately after: <input type="submit" class="button" name="addNewClose" value="<?php echo htmlspecialchars(_("Save and Finish")) ?>" /> If anyone has a better implementation, I'd love to hear it, otherwise this would make a nice enhancement.