Summary | Cannot correctly save or edit Fetchmail accounts |
Queue | IMP |
Queue Version | HEAD |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | slusarz (at) horde (dot) org |
Requester | horde (at) rajidae (dot) se |
Created | 03/12/2006 (7136 days ago) |
Due | |
Updated | 03/12/2006 (7136 days ago) |
Assigned | 03/12/2006 (7136 days ago) |
Resolved | 03/12/2006 (7136 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
account. that that was first created. Account number two and onwards
works just fine.
specifically addressed by my previous changes. If you have an invalid
entry in your fetchamail accounts list, you will have to remove it
manually.
it as "Unnamed" as the code suggests. Instead a blank account is
created.
extra blank line when no accounts has been defined. The blank line
comes from the tag not being set in the template as shown below:
<loop:accounts>
<option value="<tag:accounts.i />"><tag:accounts.val /></option>
</loop:accounts>
$fm_account->setValue('id', $id, $to_edit); get overwritten by
is overwritten by the parameter loop. To solve it move the line so
that is is under this block:
foreach ($fetchmail->getParameterList() as $val) {
$fm_account->setValue($val, Util::getFormData('fm_' . $val),
$to_edit);
}
The extra line in the empty account droplist can be fixed by moving the line
$t->set('accounts', $accountsval);
outside of the for block it is inside now.
account. that that was first created. Account number two and onwards
works just fine.
Also saving an account with an empty field for the name does not save
it as "Unnamed" as the code suggests. Instead a blank account is
created.
Related to this the the droplist showing available accounts shows an
extra blank line when no accounts has been defined. The blank line
comes from the tag not being set in the template as shown below:
<loop:accounts>
<option value="<tag:accounts.i />"><tag:accounts.val /></option>
</loop:accounts>
State ⇒ Resolved
Assigned to Michael Slusarz
if-flag not being set in template set function.
Setting the if-flag to true as below fixes the checkbox problem:
$t->set('fmonlynew', $fm_account->getValue('onlynew', $to_edit), true);
$t->set('fmmarkseen', $fm_account->getValue('markseen', $to_edit), true);
$t->set('fmdel', $fm_account->getValue('del', $to_edit), true);
$t->set('fmloginfetch', $fm_account->getValue('loginfetch', $to_edit), true);
The empty account names has to do with the default value not being set
correctly on the following line:
$id = Util::getFormData('fm_id', _("Unnamed"));
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Cannot correctly save or edit Fetchmail accounts
Queue ⇒ IMP
State ⇒ Unconfirmed
Checkbox values are not saved or set in template.
The default "Unnamed" value is never set as id when saving an account
where no name has been given. This means it is possible to save an
account without a name.