Tickets :: [#3410] Use of message

Summary	Use of message_seq wreaks havoc
Queue	Agora
Type	Bug
State	Resolved
Priority	2. Medium
Owners
Requester	chuck (at) horde (dot) org
Created	02/06/2006 (7128 days ago)
Due
Updated	10/31/2006 (6861 days ago)
Assigned
Resolved	10/31/2006 (6861 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

10/31/2006 05:04:31 PM	Jan Schneider	Comment #3 State ⇒ Resolved	Reply to this comment
Agreed.

10/31/2006 04:44:14 PM	Duck	Comment #2	Reply to this comment
The new storage structure brings a new mechanism of message and thread count. Maybe this bug can be now closed and of course the changed counting checked.

02/06/2006 03:10:39 AM	Chuck Hagenbuch	Comment #1 State ⇒ Priority ⇒ 2. Medium Type ⇒ Bug Summary ⇒ Use of message_seq wreaks havoc Queue ⇒ Agora	Reply to this comment
The overloaded use of message_seq, for both forums and threads, to represent both the next id and the count means that: - for moderated forums, the message count is inaccurate if any messages remain unmoderated - message counts for forums are innaccurate if any messages have been deleted (including messages that were denied during moderation) - last message for forums doesn't work properly if the last message is awaiting moderation ... and probably a few more. The code is messy and could really stand to be refactored, and a seperate count attribute is probably necessary.