6.0.0-alpha12
6/9/25

[#3170] Update to login.php to load preferred backend if it doesn't require authentication
Summary Update to login.php to load preferred backend if it doesn't require authentication
Queue Gollem
Queue Version HEAD
Type Enhancement
State Rejected
Priority 1. Low
Owners slusarz (at) horde (dot) org
Requester dorm (at) dorm (dot) org
Created 12/20/2005 (7111 days ago)
Due
Updated 01/12/2006 (7088 days ago)
Assigned
Resolved 01/02/2006 (7098 days ago)
Milestone
Patch No

History
01/12/2006 05:18:07 AM dorm (at) dorm (dot) org Comment #5 Reply to this comment
How about this:  Gollem goes directly to the preferred backend (if no 
specific backend was selected) if 1) there is only one backend 
configured and it does not require authentication, or, 2) multiple 
backends are configured and none require authentication.  Otherwise, 
you get the login screen as normal?



Does that seem reasonable?   I have a patch against the 1.0.2-RC1 code 
if this sounds good...
01/02/2006 07:42:17 AM dorm (at) dorm (dot) org Comment #4 Reply to this comment
The 'preferred' setting makes sense to me, that is it just for the 
default selection on the login page.



But what about the case where all configured backends do not require 
authentication?  This is what I'm running into.  I have two 'file' 
backends which map to different directories.  Neither requires 
authentication, so neither should display a login screen.



But with the current code, if I click on the 'File Manager' icon in 
the Horde tree, then instead of my 'preferred' backend getting loaded, 
I get the login screen for that backend.  Since it doesn't require 
authentication, all it is is a single "Login" button in the frame.   
After clicking this button the file listing for that preferred backend 
is displayed correctly.  But I don't think users should have to click 
that Login button, since no authentication is required.



But I see your point now, that if multiple backends are configured and 
some require auth but the preferred does not, then users would 
automatically be sent to the preferred backend and not even given the 
chance to log in to a non-preferred one.



I'm not sure what is the best way to approach this.  But I also don't 
think that the behavior I'm seeing is appropriate given my 
configuration.



If you have another way you'd like to see this solved, I'd be happy to 
make the changes and submit new patches.



Thanks.


01/02/2006 06:19:31 AM Michael Slusarz Comment #3
State ⇒ Rejected
Reply to this comment
The current gollem code loads the preferred backend only if it
doesn't require authentication *and* there is only one backend the
user has access to.
IMHO, this is the expected behavior.
This patch loads the perferred backend if it doesn't require
authentication, regardless of how many backends the user has access
to.
The preferred backend only indicates which option should be selected 
on the login screen.  'Preferred' does not mean which server should be 
automatically logged into.  In the case of only 1 available backend, 
it makes sense to autologin if no additional authentication is needed 
as there is no need for the login screen.  However, once there are 
multiple backends we shouldn't assume that the preferred backend is 
one the user wants to log into.  In fact, most of the time the 
'preferred' backend is a default selection not even selectable by the 
user (i.e. the first entry in the backends file).



Unless someone tells me I am wrong on my explanation, I am going to 
reject this request.


12/20/2005 05:08:53 PM Chuck Hagenbuch Assigned to Michael Slusarz
 
12/20/2005 04:52:51 AM dorm (at) dorm (dot) org Comment #2
New Attachment: login.php.1.94.2.7.diff Download
Reply to this comment
Patch for login.php v1.94.2.7, if needed.


12/20/2005 04:52:15 AM dorm (at) dorm (dot) org Comment #1
State ⇒ New
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Update to login.php to load preferred backend if it doesn't require authentication
Queue ⇒ Gollem
New Attachment: login.php.1.102.diff Download
Reply to this comment
The current gollem code loads the preferred backend only if it doesn't 
require authentication *and* there is only one backend the user has 
access to.



This patch loads the perferred backend if it doesn't require 
authentication, regardless of how many backends the user has access to.



I *think* I've patched the code correctly.  AFAIK from testing, it 
works as expected.  I can modify if I haven't done it right.



Thanks.

Saved Queries