Summary | bugfix (and whitespace fixes) for lib/Horde/SessionHandler/pgsql.php |
Queue | Horde Framework Packages |
Queue Version | FRAMEWORK_3 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | |
Requester | cbs (at) cts (dot) ucla (dot) edu |
Created | 10/09/2005 (7220 days ago) |
Due | |
Updated | 10/15/2005 (7214 days ago) |
Assigned | 10/11/2005 (7218 days ago) |
Resolved | 10/12/2005 (7217 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
$query = sprintf('BEGIN; SELECT session_data FROM %s WHERE ' .
but should read
$query = sprintf('SELECT session_data FROM %s WHERE ' .
State ⇒ Resolved
New Attachment: pgsql.php.diff
Taken from Chuck Hagenbuch
State ⇒ Feedback
Please re-do the patch against HEAD and we'll get it backported once
it's tested.
New Attachment: pgsql.php[1].diff
This patch modified read() to only do a SELECT FOR UPDATE on the
session id. If the row exists, this will lock it for the duration of
the transaction.
It changes write() to do a SELECT on the session id to determine if
there are any rows with that id. If there aren't any, it does an
INSERT. If there is a row it does an UPDATE. This is more closely
akin to the MySQL REPLACE INTO from mysql.php.
I am now able to authenticate and get a session. Turba, Gollem,
Kronolith, and Nag are all functioning normally as far as I can tell.
I am having problems with Imp -- trying to select a message or change
folders (anything that involves imp/message.php, imp/mailbox.php,
imp/search.php) returns me to
imp/mailbox.php?mailbox=INBOX&actionID=login
Assigned to
State ⇒ Assigned
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ bugfix (and whitespace fixes) for lib/Horde/SessionHandler/pgsql.php
Queue ⇒ Horde Framework Packages
New Attachment: pgsql.php.diff
State ⇒ Unconfirmed
not the result of the UPDATE. The current check tests
pg_rows_affected(), which is 0, and always results in true. The test
should (I think) be checking result of the UPDATE to ensure that 1 row
was updated. See the thread on horde@lists with the subject "horde
3.0.5, postgresql session handler fails" from Oct. 8 for more details.