Summary | Copy-Paste-Error in Horde Timezone Parsing |
Queue | Kronolith |
Queue Version | FRAMEWORK_5_2 |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | |
Requester | wahnes (at) uni-koeln (dot) de |
Created | 09/13/2021 (1389 days ago) |
Due | |
Updated | 12/18/2021 (1293 days ago) |
Assigned | |
Resolved | 12/18/2021 (1293 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
State ⇒ Resolved
Priority ⇒ 1. Low
Better late than never ;)
New Attachment: horde-timezone-rule-for-kronolith[1].patch
(when using a PEAR install). It seems that the the "elseif" block
was inserted using copy/paste from the previous block
before, around line 214. There, too, the '<=' case does not seem to be
handled properly, whereas the '>=' case is.
So here is a revised patch to take care of that part as well.
Priority ⇒ 2. Medium
New Attachment: horde-timezone-rule-for-kronolith.patch
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Kronolith
Summary ⇒ Copy-Paste-Error in Horde Timezone Parsing
Type ⇒ Bug
State ⇒ Unconfirmed
branch concerning the parsing of Timezone rules. The error is on line
276 of /usr/share/pear/Horde/Timezone/Rule.php (when using a PEAR
install). It seems that the the "elseif" block was inserted using
copy/paste from the previous block and that the "smaller or equal"
condition was adjusted only on the "if" line, but not on the "explode"
line. So this causes trouble with calendar entries that actually make
use of repetition rules that are valid only for certain days of a month.
I hope that the attached patch fixes the issue completely. I haven't
done a very thorough check, though.