6.0.0-git
2021-09-25

[#15075] Copy-Paste-Error in Horde Timezone Parsing
Summary Copy-Paste-Error in Horde Timezone Parsing
Queue Kronolith
Queue Version FRAMEWORK_5_2
Type Bug
State Unconfirmed
Priority 2. Medium
Owners
Requester wahnes (at) uni-koeln (dot) de
Created 2021-09-13 (12 days ago)
Due
Updated 2021-09-14 (11 days ago)
Assigned
Resolved
Milestone
Patch Yes

History
2021-09-14 00:33:47 wahnes (at) uni-koeln (dot) de Comment #2
New Attachment: horde-timezone-rule-for-kronolith[1].patch Download
Reply to this comment
The error is on line 276 of /usr/share/pear/Horde/Timezone/Rule.php 
(when using a PEAR install). It seems that the the "elseif" block 
was inserted using copy/paste from the previous block
It looks like there is a similar issue in the same file, but a bit 
before, around line 214. There, too, the '<=' case does not seem to be 
handled properly, whereas the '>=' case is.

So here is a revised patch to take care of that part as well.
2021-09-13 15:12:20 wahnes (at) uni-koeln (dot) de Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Summary ⇒ Copy-Paste-Error in Horde Timezone Parsing
Queue ⇒ Kronolith
Milestone ⇒
Patch ⇒ Yes
New Attachment: horde-timezone-rule-for-kronolith.patch Download
Reply to this comment
There is a bug in both the current Git master and the stable (5.2) 
branch concerning the parsing of Timezone rules. The error is on line 
276 of /usr/share/pear/Horde/Timezone/Rule.php (when using a PEAR 
install). It seems that the the "elseif" block was inserted using 
copy/paste from the previous block and that the "smaller or equal" 
condition was adjusted only on the "if" line, but not on the "explode" 
line. So this causes trouble with calendar entries that actually make 
use of repetition rules that are valid only for certain days of a month.

I hope that the attached patch fixes the issue completely. I haven't 
done a very thorough check, though.

Saved Queries