Summary | Do not decode TNEF attachments if AS client is Outlook |
Queue | Synchronization |
Queue Version | Git master |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | mrubinsk (at) horde (dot) org |
Requester | pachis83 (at) gmail (dot) com |
Created | 07/01/2019 (2197 days ago) |
Due | |
Updated | 08/18/2019 (2149 days ago) |
Assigned | |
Resolved | 08/18/2019 (2149 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | Yes |
Assigned to Michael Rubinsky
State ⇒ Resolved
Priority ⇒ 1. Low
Horde_Core 2.31.10
Along with a bunch of fixes for those clients that DO use the tnef decoding.
commit 3c042e55a2885a4339c46ab2f5fc6dfe36f3e3b7
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Sun, 18 Aug 2019 15:12:34 -0400
Only decode TNEF if our client can't handle natively.
For MS clients like Outlook, TNEF data can be transmitted as-is,
attempt to detect this and act accordingly.
Request: 14932M lib/Horde/ActiveSync/Device.php
M lib/Horde/ActiveSync/Imap/Adapter.php
M lib/Horde/ActiveSync/Imap/Message.php
https://github.com/horde/ActiveSync/commit/3c042e55a2885a4339c46ab2f5fc6dfe36f3e3b7
commit 4d018600c09c50d3ffdd3735e024e57324397838
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Sat, 17 Aug 2019 12:19:36 -0400
Only decode TNEF if our client can't handle natively.
For MS clients like Outlook, TNEF data can be transmitted as-is,
attempt to detect this and act accordingly.
Request: 14932M lib/Horde/ActiveSync/Device.php
M lib/Horde/ActiveSync/Imap/Adapter.php
M lib/Horde/ActiveSync/Imap/Message.php
https://github.com/horde/ActiveSync/commit/4d018600c09c50d3ffdd3735e024e57324397838
Priority ⇒ 3. High
New Attachment: Message.php
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Synchronization
Summary ⇒ Do not decode TNEF attachments if AS client is Outlook
Type ⇒ Bug
State ⇒ Unconfirmed
always decodes TNEF data, even in ActiveSync connections.
As a result, TNEF data with a Task event is received as a VTODO file
(or VTASK??? I don't remember) wich Outlook can't handle.
TNEF decoding is ok for non MS activesync clients, but when outlook is
used, TNEF data should be avoided.
In my case all the AS clients are Outlook type so I disabled TNEF
decoding commenting lines 311, 313, 414, 415, 417 in
ActiveSync/lib/Horde/ActiveSync/Imap/Message.php (attached).
Regards.