6.0.0-git
2018-12-16

[#14777] compatibility with php 7.2
Summary compatibility with php 7.2
Queue Horde Framework Packages
Type Bug
State Unconfirmed
Priority 2. Medium
Owners
Requester mail (at) webthatworks (dot) it
Created 2018-02-04 (315 days ago)
Due
Updated 2018-02-04 (315 days ago)
Assigned
Resolved
Milestone
Patch Yes

History
2018-02-04 12:56:39 mail (at) webthatworks (dot) it Comment #2 Reply to this comment
Unfortunately count() is used in too many places expecting an array 
when it is not always the case.

A more global solution should be considered other than wrapping every 
count in an if(is_array())

Too many hidden things seems fail. And waiting errors show up in the 
log doesn't seem a good way to fix this.

I'll revert to an older version of php.
2018-02-04 00:01:38 mail (at) webthatworks (dot) it Comment #1
Type ⇒ Bug
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Summary ⇒ compatibility with php 7.2
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ Yes
Reply to this comment
Hi,

there are 2 minor incompatibilities with php 7.2

1)
HORDE: PHP ERROR: ini_set(): Cannot set 'user' save handler by 
ini_set() or session_module_name() [pid 2887 on line 95 of 
"/usr/share/php/Horde/SessionHandler.php"]

line 95 can simpli be deleted

2)
HORDE: PHP ERROR: count(): Parameter must be an array or an object 
that implements Countable [pid 7442 on line 371 of 
"/usr/share/php/Horde/ActiveSync/State/Sql.php"]

         if(is_array($this->_changes)) {
           $c = count($this->_changes);
         } else {
           $c = 0;
         }
$this->_logger->meta(
             sprintf('STATE: Saving state: %s',
                 serialize(array(
                     $params['sync_key'],
                     $params['sync_data'],
                     $params['sync_devid'],
                     $params['sync_mod'],
                     $params['sync_folderid'],
                     $params['sync_user'],
                     $c,
                     time()))
                 )
             );

I hope I can publish a cleaner patch here

https://github.com/Ivan-SB/Db



Saved Queries