Summary | Javascript compression broken with closure-compiler v20170521 |
Queue | Horde Framework Packages |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | |
Requester | arjen+horde (at) de-korte (dot) org |
Created | 05/24/2017 (2996 days ago) |
Due | |
Updated | 06/02/2017 (2987 days ago) |
Assigned | 05/26/2017 (2994 days ago) |
Resolved | 06/02/2017 (2987 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | Horde_Core 2.29.1 |
Patch | No |
Milestone ⇒ Horde_Core 2.29.1
Queue ⇒ Horde Framework Packages
commit b8484ba90ed9054b463f89f1469bd1643dfc3887
Author: Jan Schneider <jan@horde.org>
Date: Fri Jun 2 10:08:37 2017 +0200
[jan] Fix JavaScript minifying with recent Closure compilers (
Bug #14650).framework/Core/package.xml | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/b8484ba90ed9054b463f89f1469bd1643dfc3887
commit 7a52bd166682280905394d48fe711e8337b6062d
Author: Jan Schneider <jan@horde.org>
Date: Fri Jun 2 10:07:23 2017 +0200
Fix encoding (
Bug #14650).framework/Core/js/date/date.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
http://github.com/horde/horde/commit/7a52bd166682280905394d48fe711e8337b6062d
commit 439b28b60813d3f01e20fbe7e2a22f69ece550ab
Author: Jan Schneider <jan@horde.org>
Date: Fri Jun 2 10:06:59 2017 +0200
Fix duplicate key warning from Closure (
Bug #14650).framework/Core/js/scriptaculous/effects.js | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
http://github.com/horde/horde/commit/439b28b60813d3f01e20fbe7e2a22f69ece550ab
New Attachment: effects.js.patch
"scaleMode", disallowed in strict mode
New Attachment: date.js.patch
New Attachment: horde-debug.log
not happy after all.
of /horde/js/date/date.js. If I change 'Claus T?ndering' to 'Claus
Tøndering', the file displays fine and makes the Closure Compiler
happy again as well. So I guess it is just the weird character name in
this comment line that is the problem.
(or any other log file either, except the horde.log). It's driving me
nuts that I can't find out what is happening here.
State ⇒ Not A Bug
I see the following:
# ll /srv/www/htdocs/horde/js/date/{date,time}.js
-rw-r--r-- 1 root root 85569 30 mei 22:57
/srv/www/htdocs/horde/js/date/date.js
-rw-r--r-- 1 root root 8675 30 mei 22:57
/srv/www/htdocs/horde/js/date/time.js
According to this, both should be readable by the wwwrun user.
However, when I attempt to 'cat' both files in the
/horde/admin/cmdshell.php, the output of the first is empty (no
output) and the latter will show the contents of the time.js file.
What?!
New Attachment: horde.log
/srv/www/htdocs/horde/js/date/date.js. Which is somewhat weird, since
the file is world readable (including all directories leading up to
it). Even stranger, the previous version of the Google Closure
Compiler didn't have any problem with the same file (and same
permissions).
State ⇒ Feedback
yourself with the unit test. There may be some problem in a certain JS
file that Closure is tripping over though. You need to take a look at
the logs to find out.
commit 3154844e43ab4ad2910d390f4af52fb7ffe43c6f
Author: Jan Schneider <jan@horde.org>
Date: Fri May 26 17:24:06 2017 +0200
Add test suite (
Bug #14650).framework/JavascriptMinify/package.xml | 34 ++++++-
.../test/Horde/JavascriptMinify/AllTests.php | 3 +
.../test/Horde/JavascriptMinify/ClosureTest.php | 67 ++++++++++++++
.../test/Horde/JavascriptMinify/NullTest.php | 37 ++++++++
.../test/Horde/JavascriptMinify/TestBase.php | 100
+++++++++++++++++++++
.../test/Horde/JavascriptMinify/UglifyjsTest.php | 67 ++++++++++++++
.../test/Horde/JavascriptMinify/YuiTest.php | 59 ++++++++++++
.../test/Horde/JavascriptMinify/bootstrap.php | 3 +
.../test/Horde/JavascriptMinify/conf.php.dist | 6 ++
.../test/Horde/JavascriptMinify/fixtures/one.js | 17 ++++
.../test/Horde/JavascriptMinify/fixtures/two.js | 47 ++++++++++
.../test/Horde/JavascriptMinify/phpunit.xml | 1 +
12 files changed, 439 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/3154844e43ab4ad2910d390f4af52fb7ffe43c6f
Priority ⇒ 1. Low
State ⇒ Unconfirmed
Patch ⇒ No
Milestone ⇒
Summary ⇒ Javascript compression broken with closure-compiler v20170521
Type ⇒ Bug
Queue ⇒ Horde Base
the compressed *.js files are all empty. The previous version
(v20170423) worked correctly.