6.0.0-beta1
7/6/25

[#14346] Error log after INSERT is not right
Summary Error log after INSERT is not right
Queue Ingo
Queue Version 3.2.10
Type Bug
State Resolved
Priority 1. Low
Owners mrubinsk (at) horde (dot) org
Requester ibon.igartua (at) ehu (dot) eus
Created 04/29/2016 (3355 days ago)
Due 04/29/2016 (3355 days ago)
Updated 10/20/2017 (2816 days ago)
Assigned 04/29/2016 (3355 days ago)
Resolved 05/03/2016 (3351 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch No

History
10/20/2017 08:33:41 PM Git Commit Comment #3 Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2):

commit 3616080cd3e1a37a866ade6818799b25e08c89f3
Author: ibon.igartua@ehu.eus <ibon.igartua@ehu.eus>
Date:   Mon, 02 May 2016 22:10:57 -0400

Bug: 14346  Log the error, not the result.

Signed-off-by: Michael J Rubinsky <mrubinsk@horde.org>

  M lib/Storage/Sql.php

https://github.com/horde/ingo/commit/3616080cd3e1a37a866ade6818799b25e08c89f3
05/03/2016 02:15:13 AM Michael Rubinsky Comment #2
State ⇒ Resolved
Reply to this comment
04/29/2016 07:37:15 PM Michael Rubinsky Assigned to Michael Rubinsky
State ⇒ Assigned
 
04/29/2016 11:36:54 AM ibon (dot) igartua (at) ehu (dot) eus Comment #1
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Error log after INSERT is not right
Due ⇒ 04/29/2016
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Reply to this comment
After adding a new address into the whitelist/blacklist the error log 
in case of a db exception after the db INSERT is printing the result 
of the query and not the error info.

I would suggest the following change at ingo/lib/Storage/Sql.php:238
<                  Horde::log($result, 'ERR');
                  Horde::log($e, 'ERR');

Saved Queries