| Summary | SyntaxHighlighter mime viewer broken in IMP using dynamic view. |
| Queue | IMP |
| Queue Version | 6.2.14 |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | mrubinsk (at) horde (dot) org |
| Requester | samuel.wolf (at) wolf-maschinenbau (dot) de |
| Created | 04/26/2016 (3355 days ago) |
| Due | |
| Updated | 07/11/2016 (3279 days ago) |
| Assigned | 04/27/2016 (3354 days ago) |
| Resolved | 07/11/2016 (3279 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
Taken from
State ⇒ Resolved
For FRAMEWORK_5_2, stops the javascript errors when loading email that
would use the MIME viewer. The part will highlight correctly in the
preview only the first time it is loaded, but not when returning to
the email after loading another email's preview. However, it will
always render correctly when loading the message in a separate window.
For master (Horde 5.3/6) same as above except the part will always be
highlighted correctly.
Summary ⇒ SyntaxHighlighter mime viewer broken in IMP using dynamic view.
This is a general issue with the way the SyntaxHighter Mime Viewer is
loaded via ajax.
package is structured and loads it's javascript files. It's
problematic in our Ajax context because we don't currently have any
way of specifying code to run after newly added script files are done
loading.
I've gotten closer, but the way we load this library needs to be
rewritten to work via our Ajax loader.
attachment, edited it to be 'inline' and now I see what is happening.
I try to copy it and remove the text/html content, but not the .xml
attachment.
Now I don't get a error, with other words the .xml file is *not* the problem.
Maybe it's time to cancel the ticket and wait for a newer Firefox version?
Some snip of the header:
Content-Type: multipart/mixed; boundary="----------=_1448297091-3720-1"
This is a multi-part message in MIME format...
------------=_1448297091-3720-1
Content-Type: multipart/alternative; boundary="----------=_1448297091-3720-0"
This is a multi-part message in MIME format...
------------=_1448297091-3720-0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Sehr geehrter Herr Wolf,
[...]
------------=_1448297091-3720-0
Content-Type: text/html; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit
<html><head><!--a75c305b1c0a6022--><meta http-equiv="Content-Type"
content="text/html; charset=utf-8"/></head><body
style="font-family:Verdana,Geneva,Helvetica,Arial,sans-serif;
font-size: 13px;">Sehr geehrter Herr Wolf,<br />
<br />
[...]
------------=_1448297091-3720-1
Content-Type: text/xml; name="template.xml"
Content-Disposition: inline; filename="template.xml"
Content-Transfer-Encoding: 7bit
<?xml version="1.0" encoding="ISO-8859-1"?>
[...]
* horde login
* open mail subfolder xy
* click on the mail with the .xml attachment --> *no* error!
* click on another mail without attachment
* click again on the mail with the .xml attachment --> ERROR
email preview, loading full email, or clicking on attachment. I'm
still not even getting the javascript loading though, so there is no
javascript to run...of course, the syntax still isn't being
highlighted though.
* horde login
* open mail subfolder xy
* click on the mail with the .xml attachment --> *no* error!
* click on another mail without attachment
* click again on the mail with the .xml attachment --> ERROR
well, back to code tracing :)
horde/js/syntaxhighlighter/scripts/shBrushXml.js ... is this there?
root@mail:/var/www/https/horde/js/syntaxhighlighter/scripts# md5sum
shBrushXml.js
ba290ac0111d2c3f8e1ce36fbaf6a239 shBrushXml.js
I guess the issue coming with the Firefox 46 update (there was a lot
of changes in js).
Firefox bug?
Chromium 50 does not show this issue.
Assigned to Michael Rubinsky
Assigned to
State ⇒ Assigned
files when loading the mime viewer. However, this would result in the
syntax not being highlighted, not the javascript pop up. I'll have to
look deeper to see why this is happening.
You should have a file in
horde/js/syntaxhighlighter/scripts/shBrushXml.js ... is this there?
State ⇒ Unconfirmed
New Attachment: horde_imp_error.png
Patch ⇒ No
Milestone ⇒
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ Mail with attached .xml file - SyntaxHighlighter error
Queue ⇒ IMP
a attached .xml file.