| Summary | gpg mail display broken |
| Queue | Horde Framework Packages |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | mrubinsk (at) horde (dot) org |
| Requester | o+horde (at) immerda (dot) ch |
| Created | 8/20/15 (3875 days ago) |
| Due | |
| Updated | 8/20/15 (3875 days ago) |
| Assigned | 8/20/15 (3875 days ago) |
| Resolved | 8/20/15 (3875 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
Queue ⇒ Horde Framework Packages
State ⇒ Resolved
State ⇒ Feedback
commit 6f245104fbfc02bceb5707c31600fffe183ab058
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Thu Aug 20 12:22:52 2015 -0400
Bug: 14090Closures do not have full access to the $this scopeprior to 5.4
While we can give it access to $this by assigning it to another
variable, that variable does not have access to non-public members.
.../Crypt/lib/Horde/Crypt/Pgp/Backend/Binary.php | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/6f245104fbfc02bceb5707c31600fffe183ab058
around that by assigning $this to another variable that IS accessible.
The issue is that we can't access the protected member from THAT
reference.
Easiest solution for now is probably to just make that method public.
State ⇒ Assigned
Assigned to Michael Slusarz
compatible with the API does not equal assurances that issues resolved
in later versions will work correctly in Horde when still using
earlier versions.
That being said, I was under the impression that it was *supposed* to
work under 5.3.x and was a bug in PHP that it did not. However, I now
see that the PHP docs state that it wasn't added until 5.4.
Assigning this to the maintainer of that code for further review.
one would expect that you announce that from now on 5.3 is not
supported anymore and remove the sentence "Although the PHP 5.3 API is
supported," from [2], or not?
since until right now we never saw a single incompatibility with 5.3....
[0] http://stackoverflow.com/questions/5734011/php-5-4-closure-this-support
[1] https://3v4l.org/neHqH
[2] http://www.horde.org/apps/horde/docs/INSTALL
Assigned to Michael Rubinsky
the mailing list somewhere. This is probably due to you having a PHP
version that didn't properly support the "$this" reference inside of
closures.
Priority ⇒ 1. Low
State ⇒ Not A Bug
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ gpg mail display broken
Queue ⇒ Horde Base
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
Horde_Crypt_Pgp_Backend_Binary::_callGpg() from context '' in
pear/php/Horde/Crypt/Pgp/Backend/Binary.php on line 155