Tickets :: [#14074] Sending notification after status change or adding comments fails

6.0.0-beta1

7/6/25

Summary	Sending notification after status change or adding comments fails
Queue	Whups
Queue Version	3.0.4
Type	Bug
State	Resolved
Priority	1. Low
Owners
Requester	heinz (at) htl-steyr (dot) ac (dot) at
Created	08/03/2015 (3625 days ago)
Due
Updated	10/29/2015 (3538 days ago)
Assigned	09/21/2015 (3576 days ago)
Resolved	10/29/2015 (3538 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

10/29/2015 12:30:34 PM	Jan Schneider	State ⇒ Resolved

10/12/2015 06:12:29 PM	heinz (at) htl-steyr (dot) ac (dot) at	Comment #7	Reply to this comment
Right, but this bit of code was corrected about 8 months ago by https://github.com/horde/horde/commit/56cff2f99ccf5b137f33e728116e584ee4124599 This commit eliminates the buggy effect but the reason lay in whups/lib/Driver.php Nevertheless this ticket should be closed since everything is working fine PS: commit b637da251ef261369594eca30af8d94efa650683 should be in the next stable release of whups

10/12/2015 12:12:01 AM	Michael Rubinsky	Comment #6	Reply to this comment
Right, but this bit of code was corrected about 8 months ago by https://github.com/horde/horde/commit/56cff2f99ccf5b137f33e728116e584ee4124599

09/21/2015 07:08:04 PM	heinz (at) htl-steyr (dot) ac (dot) at	Comment #5	Reply to this comment
It's only deprecated in newer Horde_Mime versions, but we haven't (yet) bumped the required version of Horde_Mime in Whups yet. and in older versions the public static function generateMessageId() { $hdr = new Horde_Mime_Headers(); return $hdr->generateMessageId(); } is producing an empty MessageID which is rejected by the mail server ;-)

09/21/2015 06:34:37 PM	Michael Rubinsky	Comment #4	Reply to this comment
It's only deprecated in newer Horde_Mime versions, but we haven't (yet) bumped the required version of Horde_Mime in Whups yet.

09/21/2015 06:03:34 PM	heinz (at) htl-steyr (dot) ac (dot) at	Comment #3	Reply to this comment
The only difference between master and 3.0.4 version of Driver.php is: 601c601 < $mail->addHeader('Message-ID', Horde_Mime::generateMessageId()); --- $mail->addHeaderOb(Horde_Mime_Headers_MessageId::create()); 3.0.4 version calls generateMessageId, which is marked deprecated (Mime.php: Use Horde_Mime_Headers_MessageId::create() instead.) In my installation i was using an older Mime.php -> empty MessageID -> no notification mail I think, commit 56cff2f99ccf5b137f33e728116e584ee4124599 fixed this Nevertheless, why is the stable version of whups using a deprecated method? I am still of the opinion commit b637da251ef261369594eca30af8d94efa650683 should be in the next stable release of whups

09/21/2015 04:40:08 PM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
Cannot reproduce. Message-ID headers are correctly set here.

08/03/2015 09:47:39 AM	heinz (at) htl-steyr (dot) ac (dot) at	Comment #1 Priority ⇒ 1. Low Type ⇒ Bug Summary ⇒ Sending notification after status change or adding comments fails Queue ⇒ Whups Milestone ⇒ Patch ⇒ No State ⇒ Unconfirmed	Reply to this comment
in whups/lib/Driver.php line 601 the message id is added to the header via addHeader function with an empty message id -> sending of the message fails in the git master version of whups/lib/Driver.php this is done by addHeaderOb function -> sending works i think commit b637da251ef261369594eca30af8d94efa650683 (master branche, whups now uses new Horde_Mime_Header code) is missing in this branche