Summary | Redirect function is broken in basic and smartphone mode |
Queue | IMP |
Queue Version | 6.2.8 |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | jan (at) horde (dot) org |
Requester | wahnes (at) uni-koeln (dot) de |
Created | 06/01/2015 (3685 days ago) |
Due | |
Updated | 06/03/2015 (3683 days ago) |
Assigned | |
Resolved | 06/03/2015 (3683 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 6.2.9 |
Patch | No |
State ⇒ Resolved
Milestone ⇒ 6.2.9
commit bf7eca83c5d5c3e1a14e86fb712b3a14ce2d5a97
Author: Jan Schneider <jan@horde.org>
Date: Wed Jun 3 12:28:09 2015 +0200
Reset redirect form when finished (
Bug #14002).imp/js/smartmobile.js | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/bf7eca83c5d5c3e1a14e86fb712b3a14ce2d5a97
commit 71ae517cc8749a6ab2710fc4f97aa62fbb461f7c
Author: Jan Schneider <jan@horde.org>
Date: Wed Jun 3 12:17:02 2015 +0200
Fix visibility detection.
:visibility takes ancestor into account too. And while the
redirect form is
indeed already visible at this point, the compose page is not.
Bug: 14002Conflicts:
imp/docs/CHANGES
imp/package.xml
imp/js/smartmobile.js | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/71ae517cc8749a6ab2710fc4f97aa62fbb461f7c
commit 68c355f63c4eaaeb8ef7b8daf2b415ca0c1841c3
Author: Jan Schneider <jan@horde.org>
Date: Tue Jun 2 22:45:19 2015 +0200
[jan] Fix address autocompletion in redirection window of
smartmobile mode (
Bug #14002).Conflicts:
imp/docs/CHANGES
imp/js/smartmobile.js
imp/package.xml
imp/js/smartmobile.js | 22 +++++++++++-----------
imp/templates/smartmobile/compose.html.php | 6 +++++-
2 files changed, 16 insertions(+), 12 deletions(-)
http://github.com/horde/horde/commit/68c355f63c4eaaeb8ef7b8daf2b415ca0c1841c3
commit 7ced89ecf5f49081e1741332f33ed3c896ddba3e
Author: Jan Schneider <jan@horde.org>
Date: Wed Jun 3 12:28:09 2015 +0200
Reset redirect form when finished (
Bug #14002).imp/js/smartmobile.js | 8 +++++---
1 files changed, 5 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/7ced89ecf5f49081e1741332f33ed3c896ddba3e
commit b199f80b3124b8f64b5958c6a4fc9ff5850889fb
Author: Jan Schneider <jan@horde.org>
Date: Wed Jun 3 12:17:02 2015 +0200
Fix visibility detection.
:visibility takes ancestor into account too. And while the
redirect form is
indeed already visible at this point, the compose page is not.
Bug: 14002imp/docs/CHANGES | 1 +
imp/js/smartmobile.js | 2 +-
imp/package.xml | 2 ++
3 files changed, 4 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/b199f80b3124b8f64b5958c6a4fc9ff5850889fb
commit b0dcc330c5ba437585e8a823928e61281b582841
Author: Jan Schneider <jan@horde.org>
Date: Tue Jun 2 22:45:19 2015 +0200
[jan] Fix address autocompletion in redirection window of
smartmobile mode (
Bug #14002).imp/docs/CHANGES | 2 ++
imp/js/smartmobile.js | 22 +++++++++++-----------
imp/package.xml | 2 ++
imp/templates/smartmobile/compose.html.php | 6 +++++-
4 files changed, 20 insertions(+), 12 deletions(-)
http://github.com/horde/horde/commit/b0dcc330c5ba437585e8a823928e61281b582841
commit 27f77387cbdeb36da92d0cf3b62d6f68ddd6bf09
Author: Jan Schneider <jan@horde.org>
Date: Tue Jun 2 22:00:31 2015 +0200
Do recipient check for redirection on the server side, like with
any compose mode (
Bug #14002).imp/docs/CHANGES | 2 ++
imp/js/compose.js | 6 ------
imp/lib/Compose.php | 6 ++++++
imp/package.xml | 2 ++
4 files changed, 10 insertions(+), 6 deletions(-)
http://github.com/horde/horde/commit/27f77387cbdeb36da92d0cf3b62d6f68ddd6bf09
commit eb3ecb89d4dfdd900365ca9f1da0ec809e52b7fa
Author: Jan Schneider <jan@horde.org>
Date: Tue Jun 2 21:28:21 2015 +0200
[jan] Fix cancelling redirection window in basic mode (
Bug #14002).imp/docs/CHANGES | 1 +
imp/package.xml | 4 ++--
imp/templates/basic/compose/redirect.html.php | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/eb3ecb89d4dfdd900365ca9f1da0ec809e52b7fa
Priority ⇒ 2. Medium
Type ⇒ Bug
Summary ⇒ Redirect function is broken in basic and smartphone mode
Queue ⇒ IMP
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
(1) Apparently, the Javascript code to check the email address in the
"To" field is not called the way it is when forwarding an email. That
is, no little frame is put around the (only) address entered into that
field when clicking the "Redirect" button. Instead, a Javascript alert
is shown ("You must specify a recipient"). This mostly happens if the
message is redirected to an address that is not contained in the
address book. (If the address is contained in the address book, a
small popup appears suggesting the address as one types it in, and
clicking on the "suggested" address, the little frame is put around
the address and all is fine.)
(2) The "Cancel" button in the redirect window in Basic mode doesn't
work. This is also opposed to forwarding a message where the Cancel
button works.
There are also two problem with Redirecting in Mobile
(Smartphone/Tablet) mode, but they seem to be different in nature:
(1) There is no autocompletion of addresses typed into the redirect
form (as opposed to the forward form in smartphone mode, where there
is autocompletion of addresses from the address book as one types in
addresses into the "To" field).
(2) After one types in an address into the "To" field of the Redirect
form in smartphone mode and hits the "Send Message" button, nothing
happens. At times, and endless "spinner" animation is shown, but
mostly the view just returns to the original mail that was to be
redirected. However, the mail is in fact not redirected. There is no
warning message that the mail could not be redirected (but neither is
the a confirmation that the message had been redirected, when in fact
it isn't). In Horde's logfile, there is a line
WARN: HORDE [imp] PHP ERROR: Invalid argument supplied for foreach()
[pid 21140 on line 2392 of "[...]/imp/lib/Compose.php"]