Tickets :: [#13809] deleting parent task before child task makes child unaccessible

6.0.0-beta1

7/15/25

Summary	deleting parent task before child task makes child unaccessible
Queue	Nag
Queue Version	4.2.3
Type	Bug
State	Resolved
Priority	2. Medium
Owners	jan (at) horde (dot) org, mrubinsk (at) horde (dot) org
Requester	horde (at) equaeghe (dot) nospammail (dot) net
Created	01/16/2015 (3833 days ago)
Due
Updated	12/27/2015 (3488 days ago)
Assigned	01/16/2015 (3833 days ago)
Resolved	01/16/2015 (3833 days ago)
Github Issue Link
Github Pull Request
Milestone
Patch	No

12/27/2015 07:15:06 PM	Michael Rubinsky	Comment #11	Reply to this comment
It looks like the Deleting Parent before Child bug is still causing a problem. Is there something I'm missing on getting rid of this? I've attached two pictures. Only one is attached (from your descriptions, probably #2). 1. The first is the Parent/Child relationships that are not longer responding to edit commands or visible in the eM Client Task listing. I also built another Task with the same name in the eM Client to see what would happen. It is visible and can be edited. Sorry, "eM"? 2. The error message. Regards, Jim Robinson PE The interface does not allow you to delete tasks with children. How are you deleting them? If via some external application, this is probably fixed by: https://github.com/horde/horde/commit/6e8e64b20df55a5f3eac2e5fc99fdcb270e84c4e which will be in the next bug fix release.

12/27/2015 06:28:01 PM	JRobinson (at) desglobal (dot) com	Comment #10 New Attachment: Task Crash.png	Reply to this comment
It looks like the Deleting Parent before Child bug is still causing a problem. Is there something I'm missing on getting rid of this? I've attached two pictures. 1. The first is the Parent/Child relationships that are not longer responding to edit commands or visible in the eM Client Task listing. I also built another Task with the same name in the eM Client to see what would happen. It is visible and can be edited. 2. The error message. Regards, Jim Robinson PE

03/27/2015 05:45:01 PM	Michael Rubinsky	Assigned to Michael Rubinsky

03/27/2015 05:44:33 PM	Git Commit	Comment #9	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 6144ac6958a5bb2e983469b1480fdd14689ffabf Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Mar 27 13:40:55 2015 -0400 Don't allow deletion of tasks with children (~~Bug #13809~~). This needs to be done in the controller. Couldn't find anywhere in existing code that would use the _delete() function implemented on tasks.php - maybe it's there for BC? Probably should be removed. nag/app/controllers/SaveTask.php \| 26 ++++++++++++++++---------- 1 files changed, 16 insertions(+), 10 deletions(-) http://github.com/horde/horde/commit/6144ac6958a5bb2e983469b1480fdd14689ffabf

03/27/2015 05:43:43 PM	Git Commit	Comment #8	Reply to this comment
Changes have been made in Git (master): commit fd868dc5d2f9d531b49d24b51aa52c9bb99956ef Author: Michael J Rubinsky <mrubinsk@horde.org> Date: Fri Mar 27 13:40:55 2015 -0400 Don't allow deletion of tasks with children (~~Bug #13809~~). This needs to be done in the controller. Couldn't find anywhere in existing code that would use the _delete() function implemented on tasks.php - maybe it's there for BC? Probably should be removed. nag/app/controllers/SaveTask.php \| 26 ++++++++++++++++---------- 1 files changed, 16 insertions(+), 10 deletions(-) http://github.com/horde/horde/commit/fd868dc5d2f9d531b49d24b51aa52c9bb99956ef

01/16/2015 05:30:43 PM	Git Commit	Comment #7	Reply to this comment
Changes have been made in Git (FRAMEWORK_5_2): commit 0faf58d81bee50cfe611c009866bf866cb8975eb Author: Jan Schneider <jan@horde.org> Date: Fri Jan 16 17:36:07 2015 +0100 Don't allow deletion of tasks with sub-tasks (~~Bug #13809~~). nag/task.php \| 21 +++++++++++++-------- nag/templates/view/task.inc \| 2 +- 2 files changed, 14 insertions(+), 9 deletions(-) http://github.com/horde/horde/commit/0faf58d81bee50cfe611c009866bf866cb8975eb

01/16/2015 05:26:36 PM	Jan Schneider	Assigned to Jan Schneider State ⇒ Resolved

01/16/2015 05:24:17 PM	Git Commit	Comment #6	Reply to this comment
Changes have been made in Git (master): commit 73c991cf01b8a8d4c123b555c6590d3982a9562e Author: Jan Schneider <jan@horde.org> Date: Fri Jan 16 17:36:07 2015 +0100 Don't allow deletion of tasks with sub-tasks (~~Bug #13809~~). nag/task.php \| 21 +++++++++++++-------- nag/templates/view/task.inc \| 2 +- 2 files changed, 14 insertions(+), 9 deletions(-) http://github.com/horde/horde/commit/73c991cf01b8a8d4c123b555c6590d3982a9562e

01/16/2015 03:47:43 PM	horde (at) equaeghe (dot) nospammail (dot) net	Comment #5	Reply to this comment
We prohibit the deletion of parent tasks if child tasks still exist, at least in theory. So how did you actually delete the parent task? These steps worked for me (you may wish to try this in a fresh task list): 1. create task titled "parent-task" 2. create task titled "child task" with parent "parent-task" 3. click "parent-task" in the task list 4. click the remove (delete?) button in the button row on top 5. confirm ("task-parent" deleted) 6. click "child-task" in the task list (error message appears, nothing else happens)

01/16/2015 03:29:34 PM	Jan Schneider	Comment #4	Reply to this comment
We prohibit the deletion of parent tasks if child tasks still exist, at least in theory. So how did you actually delete the parent task?

01/16/2015 03:20:54 PM	horde (at) equaeghe (dot) nospammail (dot) net	Comment #3	Reply to this comment
When a parent tag is deleted before a child tag, the child tag becomes unaccessible: I assume you mean "Task" here, and not "Tag"? Yes, sorry. Furthermore, the calendar becomes unsyncable (via CalDav) from Lightning, the Thunderbird calendar component. Do you really mean the calendar or do you mean the task list? Well, it is a calendar from the Lightning perspective (it is an iCalendar client, so it deals with VCalendars), but from the Horde UI perspective, indeed, it is a task list. (Many clients allow calendar entries and todos in the same calendar file). Currently the only workaround I found is to create a new calendar and copy move all non-orphaned tasks to there and delete the old one, with the orphans still there. Again, do you mean Calendar, or Task list here? As above.

01/16/2015 03:14:39 PM	Michael Rubinsky	Comment #2 State ⇒ Feedback	Reply to this comment
When a parent tag is deleted before a child tag, the child tag becomes unaccessible: I assume you mean "Task" here, and not "Tag"? any attempt to access it causes a error message ?Task not found? to be displayed and no action to be taken. Furthermore, the calendar becomes unsyncable (via CalDav) from Lightning, the Thunderbird calendar component. Do you really mean the calendar or do you mean the task list? When I iCal-export the task list, the Related-To attribute of the the child task is still there, empty. This may be relevant. Currently the only workaround I found is to create a new calendar and copy move all non-orphaned tasks to there and delete the old one, with the orphans still there. Again, do you mean Calendar, or Task list here?

01/16/2015 11:47:15 AM	horde (at) equaeghe (dot) nospammail (dot) net	Comment #1 Patch ⇒ No State ⇒ Unconfirmed Milestone ⇒ Queue ⇒ Nag Summary ⇒ deleting parent task before child task makes child unaccessible Type ⇒ Bug Priority ⇒ 2. Medium	Reply to this comment
When a parent tag is deleted before a child tag, the child tag becomes unaccessible: any attempt to access it causes a error message ?Task not found? to be displayed and no action to be taken. Furthermore, the calendar becomes unsyncable (via CalDav) from Lightning, the Thunderbird calendar component. When I iCal-export the task list, the Related-To attribute of the the child task is still there, empty. This may be relevant. Currently the only workaround I found is to create a new calendar and copy move all non-orphaned tasks to there and delete the old one, with the orphans still there. Is there a faster workaround for solving this problem, deleting the orphaned tasks in some way, or ?editing the raw iCal??