| Summary | Refactor away dual stream handles in Bundled implementation |
| Queue | Horde Framework Packages |
| Type | Enhancement |
| State | Resolved |
| Priority | 1. Low |
| Owners | mrubinsk (at) horde (dot) org |
| Requester | mrubinsk (at) horde (dot) org |
| Created | 01/08/2015 (3977 days ago) |
| Due | |
| Updated | 02/09/2015 (3945 days ago) |
| Assigned | 01/08/2015 (3977 days ago) |
| Resolved | 02/09/2015 (3945 days ago) |
| Milestone | |
| Patch | No |
State ⇒ Resolved
commit 9f765cdb32481fe2b6182c5d1e18940a948c8236
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Feb 9 11:53:55 2015 -0500
Remove debug code.
See
Bug: 13788.../Image/lib/Horde/Image/Exif/Parser/Gps.php | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/9f765cdb32481fe2b6182c5d1e18940a948c8236
commit 61d0d93a3f0c272ca826a9a81d9ea428ee155c62
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Feb 9 11:53:11 2015 -0500
Fix Horde_Stream::seek ussage.
See
Bug: 13788framework/Image/lib/Horde/Image/Exif/Bundled.php | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
http://github.com/horde/horde/commit/61d0d93a3f0c272ca826a9a81d9ea428ee155c62
commit 8ac25d706e318b77246147ef7c06e4f921361e4e
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Feb 9 11:24:36 2015 -0500
Sanity check.
See
Bug: 13788framework/Image/lib/Horde/Image/Exif/Bundled.php | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
http://github.com/horde/horde/commit/8ac25d706e318b77246147ef7c06e4f921361e4e
commit 5131f30600253ffca22c4fd26ab1d7c91b02d558
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Feb 9 11:21:50 2015 -0500
First pass at removing extra stream.
See
Bug: 13788framework/Image/lib/Horde/Image/Exif/Bundled.php | 135
+++++++++-----------
.../Image/lib/Horde/Image/Exif/Parser/Canon.php | 9 +-
.../Image/lib/Horde/Image/Exif/Parser/Gps.php | 15 +-
.../Image/lib/Horde/Image/Exif/Parser/Olympus.php | 2 +-
.../Image/lib/Horde/Image/Exif/Parser/Sanyo.php | 7 +-
5 files changed, 77 insertions(+), 91 deletions(-)
http://github.com/horde/horde/commit/5131f30600253ffca22c4fd26ab1d7c91b02d558
Priority ⇒ 1. Low
Type ⇒ Enhancement
Summary ⇒ Refactor away dual steam handles in Bundled implementation
Queue ⇒ Horde Framework Packages
Assigned to Michael Rubinsky
Milestone ⇒
Patch ⇒ No
State ⇒ Assigned
[Hide Quoted Text]
commit 8e28721b86544127b272855dad9855bf453b51c0
Author: Michael M Slusarz <slusarz@horde.org>
Date: Tue Jan 6 22:31:54 2015 -0700
[mms] Horde_Image_Exif_Bundled now supports reading data from a
PHP stream, rather than a file.
framework/Image/lib/Horde/Image/Exif/Bundled.php | 55 +++++++++++++++++----
framework/Image/package.xml | 12 ++--
2 files changed, 50 insertions(+), 17 deletions(-)
http://github.com/horde/horde/commit/8e28721b86544127b272855dad9855bf453b51c0
Would be really great if we could get rid of the dual handle accesses
in here (there's no reason this can't be accomplished with a single
stream). I just wanted to get this to work, so we are copying the
data stream to a separate data stream to work with the current code.
For the record: Not using the other exif drivers because this needs to
be done in-memory. Saving to temp file to use exif binary or base64
encoding to a data URL in order to use PHP's built-in exif handling is
way too expensive.