| Summary | fatal error if in backend 'preferred' is an array |
| Queue | Ingo |
| Queue Version | 3.2.1 |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | mrubinsk (at) horde (dot) org, slusarz (at) horde (dot) org |
| Requester | weis (at) kip (dot) uni-heidelberg (dot) de |
| Created | 09/06/2014 (3978 days ago) |
| Due | |
| Updated | 11/03/2014 (3920 days ago) |
| Assigned | |
| Resolved | 09/08/2014 (3976 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | No |
Assigned to Michael Slusarz
commit 3fc53d075cf3a924d0b5892def1f4c111f5a5372
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sun Nov 2 21:45:04 2014 -0700
[mms] Fix determination of preferred backend (
Bug #13548).Conflicts:
ingo/package.xml
ingo/docs/CHANGES | 7 +++++++
ingo/lib/Session.php | 2 +-
ingo/package.xml | 14 +++++++++++++-
3 files changed, 21 insertions(+), 2 deletions(-)
http://github.com/horde/horde/commit/3fc53d075cf3a924d0b5892def1f4c111f5a5372
commit 72b1da6b950c6c1b49e498c087f61286c9fd3f5a
Author: Michael M Slusarz <slusarz@horde.org>
Date: Sun Nov 2 21:45:04 2014 -0700
[mms] Fix determination of preferred backend (
Bug #13548).ingo/docs/CHANGES | 1 +
ingo/lib/Session.php | 2 +-
ingo/package.xml | 4 ++--
3 files changed, 4 insertions(+), 3 deletions(-)
http://github.com/horde/horde/commit/72b1da6b950c6c1b49e498c087f61286c9fd3f5a
New Attachment: ingo.patch
$backend = $v;
should be
$backend = $val;
Find attached patch.
State ⇒ Resolved
commit 5c840a6cab3bca396b3ed0cd964fbdb9450937ed
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Sep 8 09:44:58 2014 -0400
Bug: 13548Fix variable name in for loop.ingo/lib/Session.php | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
http://github.com/horde/horde/commit/5c840a6cab3bca396b3ed0cd964fbdb9450937ed
commit 2889fe664050b58460dbe4279cd7f0f8c829fde4
Author: Michael J Rubinsky <mrubinsk@horde.org>
Date: Mon Sep 8 09:44:58 2014 -0400
Bug: 13548Fix variable name in for loop.ingo/lib/Session.php | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
http://github.com/horde/horde/commit/2889fe664050b58460dbe4279cd7f0f8c829fde4
Priority ⇒ 1. Low
Type ⇒ Bug
Summary ⇒ fatal error if in backend 'preferred' is an array
Queue ⇒ Ingo
Milestone ⇒
Patch ⇒ No
State ⇒ Unconfirmed
No "script" element found in backend configuration.
In the backend definition of ingo 'script' was defined.
The error traced back to
_getBackend() ....ingo/lib/Session.php:47
where I found the reason:
In file ingo/lib/Session.php (line 126):
foreach ($val['preferred'] as $val) {
if (($val == $_SERVER['SERVER_NAME']) ||
($val == $_SERVER['HTTP_HOST'])) {
$backend = $val;
}
}
This code is only used, if 'preferred' in the backend definition is an array.
$val is used in two meanings and the 'foreach' overwrites the first one.
It should be more like this:
foreach ($val['preferred'] as $v) {
if (($v == $_SERVER['SERVER_NAME']) ||
($v == $_SERVER['HTTP_HOST'])) {
$backend = $v;
}
}
sorry, don't know how make a patch for this