Summary | bug in javascript call when filtering based on keyword |
Queue | Midas |
Queue Version | HEAD |
Type | Bug |
State | Resolved |
Priority | 2. Medium |
Owners | mdjukic (at) |
Requester | email (at) teletechnics (dot) com |
Created | 04/26/2004 (7744 days ago) |
Due | |
Updated | 05/02/2004 (7738 days ago) |
Assigned | 04/28/2004 (7742 days ago) |
Resolved | 05/02/2004 (7738 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | |
Patch | No |
State ⇒ Resolved
small typos, errors and miscalculations, which all put together meant
erratic results.
State ⇒ Assigned
ie. calling
http://site.com/midas/ad.php?d=js
the output may be
document.write('');
**note empty quotes
or
document.write('[IMAGE]');
** ie correct
or
Notice: Undefined offset: 3 in
/usr/local/etc/httpd/vhosts/horde-cvs/midas/lib/Campaigns.php on line
102
document.write('[IMAGE]');
setting a k=KEYWORD
does not actually restrict selection to the ones with a (the) KEYWORD
set, but seems show any ad available.
State ⇒ Resolved
Priority ⇒ 2. Medium
Assigned to mdjukic
State ⇒ Unconfirmed
Priority ⇒ 2. Medium
Type ⇒ Bug
Queue ⇒ Midas
http://i-pt.securesites.com/midas/ad.php?d=js&k=KEYWORD
returns errors:
Notice: Undefined variable: keyword in
/usr/local/etc/httpd/vhosts/horde-cvs/midas/lib/Campaigns.php on line
115
Fatal error: Call to a member function on a non-object in
/usr/local/etc/httpd/vhosts/horde-cvs/midas/lib/Campaigns.php on line
118
Error 1 is fixed by changing
/* Split up all the keywords into an array consisting only of
* unique keywords. */
- $target_words = array_unique(preg_split('|\s+|', $keyword));
+ $target_words = array_unique(preg_split('|\s+|', $target_words));
}
$avail_words = $this->_campaigns->getKeywords('active');
Error 2
I have tried to follow the code and cannot find anything. So was
hoping if someone else could cast an eye on this.
Thanks,
tim.