Summary | Fatal authentication error not catched |
Queue | IMP |
Queue Version | Git develop |
Type | Bug |
State | Resolved |
Priority | 1. Low |
Owners | jan (at) horde (dot) org, slusarz (at) horde (dot) org |
Requester | jan (at) horde (dot) org |
Created | 07/20/2012 (4730 days ago) |
Due | |
Updated | 10/16/2012 (4642 days ago) |
Assigned | 09/10/2012 (4678 days ago) |
Resolved | 10/16/2012 (4642 days ago) |
Github Issue Link | |
Github Pull Request | |
Milestone | 6 |
Patch | No |
more specifically that it's the IMAP server we're waiting for. But
if what you describe is the desired behavior (and it makes sense
indeed), I think this ticket can be closed.
But this is the expected behavior (the list of Exception codes that
will cause an authentication failure can be found in
IMP_Imap_Exception#authException(), FWIW).
State ⇒ Resolved
specifically that it's the IMAP server we're waiting for. But if what
you describe is the desired behavior (and it makes sense indeed), I
think this ticket can be closed.
commit fee90723e5b2ce33f1a847e2342345e655ea3b32
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Oct 5 18:25:26 2012 -0600
Bug #11297: Ignore IMAP issues when doing the newmail check.../Handler/Decorator/NewmailNotify.php | 23
+++++++++++++-------
1 files changed, 15 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/fee90723e5b2ce33f1a847e2342345e655ea3b32
logged into IMP, right?), but this should fix the authentication
exception.
server. The point is that we need to gracefully handle if something
happens on the server side.
cached IMAP session object becoming invalid. I wasn't aware that this
issue was caused by known downtime in the IMAP server.
in IMP fails. But inside IMP, this is still not correctly handled.
AJAX requests get an empty response, i.e. the user is not logged out
of IMP.
server not reachable on the network? The latter will NOT cause a
logout (since it is not an authentication error - once authenticated,
it is assumed the user remains authenticated until the server
explicitly indicates authentication is wrong).
already logged into IMP, right?), but this should fix the
authentication exception.
server. The point is that we need to gracefully handle if something
happens on the server side.
Regular pages continue to work fine now even if IMAP authentication in
IMP fails. But inside IMP, this is still not correctly handled. AJAX
requests get an empty response, i.e. the user is not logged out of IMP.
logged into IMP, right?), but this should fix the authentication
exception.
commit fee90723e5b2ce33f1a847e2342345e655ea3b32
Author: Michael M Slusarz <slusarz@horde.org>
Date: Fri Oct 5 18:25:26 2012 -0600
Bug #11297: Ignore IMAP issues when doing the newmail check.../Handler/Decorator/NewmailNotify.php | 23
+++++++++++++-------
1 files changed, 15 insertions(+), 8 deletions(-)
http://git.horde.org/horde-git/-/commit/fee90723e5b2ce33f1a847e2342345e655ea3b32
Noticed when trying to access some admin page when I'm still
authenticated at Horde as an admin, but the imap authentication fails.
1. require() /home/jan/horde-develop/horde/admin/locks.php:58
2. Horde_Notification_Handler->notify()
/home/jan/horde-develop/horde/templates/admin/menu.inc:22
3. IMP_Notification_Handler_Decorator_NewmailNotify->notify()
/home/jan/horde-develop/framework/Notification/lib/Horde/Notification/Handler.php:317
4. IMP_Imap->statusMultiple()
/home/jan/horde-develop/imp/lib/Notification/Handler/Decorator/NewmailNotify.php:55
5. IMP_Imap->__call()
/home/jan/horde-develop/imp/lib/Notification/Handler/Decorator/NewmailNotify.php:55
6. IMP_Imap_Exception->authException()
/home/jan/horde-develop/imp/lib/Imap.php:382
7. require() /home/jan/horde-develop/horde/admin/locks.php:58
8. Horde_Notification_Handler->notify()
/home/jan/horde-develop/horde/templates/admin/menu.inc:22
9. IMP_Notification_Handler_Decorator_NewmailNotify->notify()
/home/jan/horde-develop/framework/Notification/lib/Horde/Notification/Handler.php:317
10. IMP_Imap->statusMultiple()
/home/jan/horde-develop/imp/lib/Notification/Handler/Decorator/NewmailNotify.php:55
11. IMP_Imap->__call()
/home/jan/horde-develop/imp/lib/Notification/Handler/Decorator/NewmailNotify.php:55
12. require() /home/jan/horde-develop/horde/admin/locks.php:58
13. Horde_Notification_Handler->notify()
/home/jan/horde-develop/horde/templates/admin/menu.inc:22
14. IMP_Notification_Handler_Decorator_NewmailNotify->notify()
/home/jan/horde-develop/framework/Notification/lib/Horde/Notification/Handler.php:317
15. IMP_Imap->statusMultiple()
/home/jan/horde-develop/imp/lib/Notification/Handler/Decorator/NewmailNotify.php:55
16. IMP_Imap->__call()
/home/jan/horde-develop/imp/lib/Notification/Handler/Decorator/NewmailNotify.php:55
17. call_user_func_array() /home/jan/horde-develop/imp/lib/Imap.php:377
18. Horde_Imap_Client_Base->statusMultiple()
19. Horde_Imap_Client_Base->login()
/home/jan/horde-develop/framework/Imap_Client/lib/Horde/Imap/Client/Base.php:1638
20. Horde_Imap_Client_Socket->_login()
/home/jan/horde-develop/framework/Imap_Client/lib/Horde/Imap/Client/Base.php:751
Assigned to Jan Schneider
Milestone ⇒ 6
State ⇒ Feedback
Noticed when trying to access some admin page when I'm still
authenticated at Horde as an admin, but the imap authentication fails.
State ⇒ Assigned
Noticed when trying to access some admin page when I'm still
authenticated at Horde as an admin, but the imap authentication fails.
commit 96fd1c55dc90178e28a0438de5a02935b33f9894
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Jul 25 06:06:32 2012 -0600
[mms] Better handling of backend authentication errors when
returning AJAX data (
Bug #11297).horde/docs/CHANGES | 2 ++
horde/package.xml | 4 ++--
horde/services/ajax.php | 24 +++++++++++++++---------
3 files changed, 19 insertions(+), 11 deletions(-)
http://git.horde.org/horde-git/-/commit/96fd1c55dc90178e28a0438de5a02935b33f9894
commit 74aca6034de39ed08821a74adc7fac6de9094bea
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Jul 25 06:06:08 2012 -0600
[mms] Add a no authentication AJAX handler (
Bug #11297).framework/Core/js/hordecore.js | 1 +
.../Horde/Core/Ajax/Response/HordeCore/NoAuth.php | 62
++++++++++++++++++++
framework/Core/package.xml | 2 +
3 files changed, 65 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/74aca6034de39ed08821a74adc7fac6de9094bea
State ⇒ Resolved
commit 96fd1c55dc90178e28a0438de5a02935b33f9894
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Jul 25 06:06:32 2012 -0600
[mms] Better handling of backend authentication errors when
returning AJAX data (
Bug #11297).horde/docs/CHANGES | 2 ++
horde/package.xml | 4 ++--
horde/services/ajax.php | 24 +++++++++++++++---------
3 files changed, 19 insertions(+), 11 deletions(-)
http://git.horde.org/horde-git/-/commit/96fd1c55dc90178e28a0438de5a02935b33f9894
commit 74aca6034de39ed08821a74adc7fac6de9094bea
Author: Michael M Slusarz <slusarz@horde.org>
Date: Wed Jul 25 06:06:08 2012 -0600
[mms] Add a no authentication AJAX handler (
Bug #11297).framework/Core/js/hordecore.js | 1 +
.../Horde/Core/Ajax/Response/HordeCore/NoAuth.php | 62
++++++++++++++++++++
framework/Core/package.xml | 2 +
3 files changed, 65 insertions(+), 0 deletions(-)
http://git.horde.org/horde-git/-/commit/74aca6034de39ed08821a74adc7fac6de9094bea
Priority ⇒ 1. Low
State ⇒ Assigned
Patch ⇒ No
Milestone ⇒
Assigned to Michael Slusarz
Summary ⇒ Fatal authentication error not catched
Type ⇒ Bug
Queue ⇒ IMP
authentication method could be found". I am not sure why this happens,
probably something going icky on the IMAP server.
That's not the point though, the problem is, that this error is not
correctly catched, i.e. the user is not re-authenticated or thrown
back to the login screen.