Tickets :: [#8128] Enhancements for String::substr

6.0.0-beta1

11/8/25

Summary	Enhancements for String::substr
Queue	Horde Framework Packages
Queue Version	HEAD
Type	Enhancement
State	Resolved
Priority	1. Low
Owners	jan (at) horde (dot) org
Requester	jens (at) peino (dot) de
Created	03/30/2009 (6067 days ago)
Due
Updated	03/30/2009 (6067 days ago)
Assigned
Resolved	03/30/2009 (6067 days ago)
Milestone
Patch	Yes

03/30/2009 03:31:41 PM	CVS Commit	Comment #8	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Util/String.php?rt=horde&r1=1.43.6.36&r2=1.43.6.37&ty=u http://cvs.horde.org/diff.php/horde/docs/CHANGES?rt=horde&r1=1.515.2.516&r2=1.515.2.517&ty=u

03/30/2009 03:23:37 PM	Jan Schneider	Comment #7 Assigned to Jan Schneider State ⇒ Resolved	Reply to this comment
Committed, thanks.

03/30/2009 03:22:09 PM	CVS Commit	Comment #6	Reply to this comment
Changes have been made in CVS for this ticket: http://cvs.horde.org/diff.php/framework/Util/String.php?rt=horde&r1=1.94&r2=1.95&ty=u

03/30/2009 02:11:33 PM	Jan Schneider	Deleted Original Message

03/30/2009 01:28:40 PM	jens (at) peino (dot) de	Comment #5 New Attachment: framework_utils_String[1].patch	Reply to this comment
New patch attached. Previous had bad whitespaces and windows lineendings. Sorry.

03/30/2009 01:18:32 PM	Jan Schneider	Comment #4	Reply to this comment
patch framework_cvs/Util/String.php < framework_utils_String.patch (Stripping trailing CRs from patch.) patching file framework_cvs/Util/String.php Hunk #1 FAILED at 340. patch unexpectedly ends in middle of line Hunk #2 FAILED at 358. 2 out of 2 hunks FAILED -- saving rejects to file framework_cvs/Util/String.php.rej

03/30/2009 01:12:33 PM	jens (at) peino (dot) de	Comment #3	Reply to this comment
The patch doesn't apply. What do _you_ mean? Is broken? Or not is it not appropriate? - Jens

03/30/2009 12:59:38 PM	Jan Schneider	Comment #2 State ⇒ Feedback	Reply to this comment
The patch doesn't apply.

03/30/2009 08:04:55 AM	jens (at) peino (dot) de	Comment #1 State ⇒ New New Attachment: framework_utils_String.patch Patch ⇒ Yes Milestone ⇒ Queue ⇒ Horde Framework Packages Summary ⇒ Enhancements for String::substr Type ⇒ Enhancement Priority ⇒ 1. Low	Reply to this comment
1.) iconv_substr throws an error notice when then source string contains an illegal character. -> Use same suppression like done for the case mbstring is enabled. 2.) iconv_substr returns anyway -> Go ahead in case of error and try the other available ways.