6.0.0-git
2021-01-18

[#8128] Enhancements for String::substr
Summary Enhancements for String::substr
Queue Horde Framework Packages
Queue Version HEAD
Type Enhancement
State Resolved
Priority 1. Low
Owners jan (at) horde (dot) org
Requester jens (at) peino (dot) de
Created 2009-03-30 (4312 days ago)
Due
Updated 2009-03-30 (4312 days ago)
Assigned
Resolved 2009-03-30 (4312 days ago)
Milestone
Patch Yes

History
2009-03-30 15:23:37 Jan Schneider Comment #7
Assigned to Jan Schneider
State ⇒ Resolved
Reply to this comment
Committed, thanks.
2009-03-30 15:22:09 CVS Commit Comment #6 Reply to this comment
2009-03-30 14:11:33 Jan Schneider Deleted Original Message
 
2009-03-30 13:28:40 jens (at) peino (dot) de Comment #5
New Attachment: framework_utils_String[1].patch Download
Reply to this comment
New patch attached. Previous had bad whitespaces and windows lineendings.



Sorry.
2009-03-30 13:18:32 Jan Schneider Comment #4 Reply to this comment
patch framework_cvs/Util/String.php < framework_utils_String.patch

(Stripping trailing CRs from patch.)

patching file framework_cvs/Util/String.php

Hunk #1 FAILED at 340.

patch unexpectedly ends in middle of line

Hunk #2 FAILED at 358.

2 out of 2 hunks FAILED -- saving rejects to file 
framework_cvs/Util/String.php.rej


2009-03-30 13:12:33 jens (at) peino (dot) de Comment #3 Reply to this comment
The patch doesn't apply.
What do _you_ mean?

Is broken? Or not is it not appropriate?



- Jens
2009-03-30 12:59:38 Jan Schneider Comment #2
State ⇒ Feedback
Reply to this comment
The patch doesn't apply.
2009-03-30 08:04:55 jens (at) peino (dot) de Comment #1
Type ⇒ Enhancement
State ⇒ New
Priority ⇒ 1. Low
Summary ⇒ Enhancements for String::substr
Queue ⇒ Horde Framework Packages
Milestone ⇒
Patch ⇒ Yes
New Attachment: framework_utils_String.patch
Reply to this comment
1.) iconv_substr throws an error notice when then source string 
contains an illegal character.

-> Use same suppression like done for the case mbstring is enabled.



2.) iconv_substr returns anyway

-> Go ahead in case of error and try the other available ways.

Saved Queries