| Summary | fix bug: sftp operations in VFS/ssh2.php do not work due to escapeshellarg |
| Queue | Horde Framework Packages |
| Queue Version | FRAMEWORK_3 |
| Type | Bug |
| State | Resolved |
| Priority | 1. Low |
| Owners | |
| Requester | odie (at) cs (dot) aau (dot) dk |
| Created | 09/08/2008 (6142 days ago) |
| Due | |
| Updated | 09/08/2008 (6142 days ago) |
| Assigned | |
| Resolved | 09/08/2008 (6142 days ago) |
| Github Issue Link | |
| Github Pull Request | |
| Milestone | |
| Patch | Yes |
http://cvs.horde.org/diff.php/framework/VFS/lib/VFS/ssh2.php?r1=1.10&r2=1.11&ty=u
the Watch feature in an attempt to get directly in touch with the
people involved in
[#6756] ssh2_scp_recv fails if pathnames contain special characters
Chuck Hagenbuch and "herde", please see
Ticket URL: http://bugs.horde.org/ticket/7301
Thanks,
Simon Holm Thøgersen
Priority ⇒ 1. Low
New Attachment: horde-ssh2.php.diff
Patch ⇒ Yes
Milestone ⇒
Queue ⇒ Horde Framework Packages
Summary ⇒ fix bug: sftp operations in VFS/ssh2.php do not work due to escapeshellarg
Type ⇒ Bug
State ⇒ Unconfirmed
escapeshellarg'ed, white spaces and other special characters are
already handled fine by these functions. This is opposed to the
ssh_scp_* functions that do require them.
The escapeshellarg was introduced when trying to fix a problem where
the ssh_scp_* functions did not use escapeshellarg (
bug #6756). ChuckHagenbuch must have guessed that the ssh2_sftp_* functions required
them too, but neither he nor the reporter of the bug seemed to have
actually tested any codepaths that uses the ssh2_sftp_* functions.
Attached is a patch that reverts the code for the ssh_sftp_* functions
to the state before the 'fix'.
I'm CC'ing the people involved in
bug #6756to get their statement.