[#5912] set start and stop times for maildrop vacation recipes
| Summary | set start and stop times for maildrop vacation recipes |
| Queue | Ingo |
| Queue Version | HEAD |
| Type | Enhancement |
| State | No Feedback |
| Priority | 1. Low |
| Owners | |
| Requester | steinkel (at) ctinetworks (dot) com |
| Created | 11/21/2007 (172 days ago) |
| Due | |
| Updated | 04/16/2008 (25 days ago) |
| Assigned | |
| Resolved | 04/16/2008 (25 days ago) |
| Attachments | maildrop.vacation.diff  |
| Milestone | |
| Patch |
Ping?>> What does the extra trimming of the email addresses do and why?
>
> The extra trims in the foreach loop are from paranoia about too many
> exploits using embedded control characters in mail headers.
Shouldn't this rather be done through addcslashes() like anywhere else in the maildrop driver?
>> What's about the currently outcommented ignorelist stuff a few lines
>> above? Can this go now?
>
> I redid the ignorelist regex to simplify it for debugging my code.
> It can certainly be bulked-up, but I think the original ignorelist is
> not workable in its current form. I am using it now as it sits.
I consider this as a "yes."
> What does the extra trimming of the email addresses do and why?
The extra trims in the foreach loop are from paranoia about too many exploits using embedded control characters in mail headers.
> What's about the currently outcommented ignorelist stuff a few lines
> above? Can this go now?
I redid the ignorelist regex to simplify it for debugging my code. It can certainly be bulked-up, but I think the original ignorelist is not workable in its current form. I am using it now as it sits.
What does the extra trimming of the email addresses do and why?What's about the currently outcommented ignorelist stuff a few lines above? Can this go now?
New Attachment: maildrop.vacation.diff
Here is the latest diff, including start and end times, list/bulk/junk/admin mail ignoring, and excluded addresses. I simplified the admin mail regexp for debugging purposes.State ⇒ Feedback
> please move the "current_time=time" line before the vacation> start/end time checks
Please provide an updated patch.
After you have rendered judgement on these, I have suggestions for handling exclusions as wellplease move the "current_time=time" line before the vacation start/end time checksNew Attachment: updated.vacation.diff
Here is the latest diff against CVS HEAD, including 'ignorelist' checking.
In the future, I will do more testing before posting.
> This has been lightly tested.
Heavier testing led to the addition to an else clause at the end, so the generated reply is not delivered to the local mailbox
=== add after line 518 ===
$this->_action[] = ' else';
$this->_action[] = ' {';
$this->_action[] = ' to "/dev/null";';
$this->_action[] = ' }';
New Attachment: vacation.diff
Type ⇒ Enhancement
Priority ⇒ 1. Low
Summary ⇒ set start and stop times for maildrop vacation recipes
Queue ⇒ Ingo
State ⇒ New
This has been lightly tested.