Tickets :: Comment on [#9826] Schema checking broken in Turba_Driver

* Your Email Address
* Spam protection	Enter the letters below: .___ ..__.. .. . [__ \|[__]\|\/\|\|\/\| \| \__\|\| \|\| \|\| \|
Comment	> I upgraded to PEAR package Horde_Ldap version 1.1.0 > There is still a problem in class Horde_Ldap_Schema. > If there is an objectclass with no must attributes but superclasses > would have one, > an empty array is returned. > current code: > public function must($oc, $checksup = false) > { > try { > $attributes = $this->_getAttr($oc, 'must'); > if ($checksup) { > foreach ($this->superclass($oc) as $sup) { > $attributes = array_merge($attributes, > $this->must($sup)); > } > $attributes = array_values(array_unique($attributes)); > } > return $attributes; > } catch (Horde_Ldap_Exception $e) { > return array(); > } > } > > _getAttr throws an Exception and if catched an empty arry ist > returned, no superclass is called > Possible solution: > public function must($oc, $checksup = false) > { > try { > $attributes = $this->_getAttr($oc, 'must'); > } catch (Horde_Ldap_Exception $e) { > $attributes = array(); > } > > if ($checksup) { > foreach ($this->superclass($oc) as $sup) { > $attributes = array_merge($attributes, > $this->must($sup, true)); > } > $attributes = array_values(array_unique($attributes)); > } > return $attributes; > } > >
Attachment
Watch this ticket