Tickets :: Comment on [#9369] Use ckeditor preferences on signatures too

* Your Email Address
* Spam protection	Enter the letters below: . . .. ..__ . . \|\ \| \|\|\/\|[__)\|\/\| \| \\|\__\|\| \|\| \\| \|
Comment	>>> We should NEVER be manually entering CKEDITOR.replace() calls in .js >>> files - this is done by IMP_Ui_Editor::.. >> But this is the compose-dimp.js behavior: >> https://github.com/horde/horde/blob/master/imp/js/compose-dimp.js#L438 > > This is a special case - it is needed because the HTML editor is > being toggled within the page. All other uses of HTML editor should > be initialized automatically by calling Horde_Editor_Ckeditor. > >>> Sure enough, it appears in the page output: >>> >>> <!--a75c305b1c0a6022--><script type="text/javascript" >>> src="/horde/imp/js/signaturehtml.js"></script> >>> <!--a75c305b1c0a6022--><script type="text/javascript">//<![CDATA[ >>> Event.observe(window, "load", function() >>> {CKEDITOR.replace("signature_html",{"scayt_autoStartup":false});});window.IMP >>> = >>> [...] >> Thats the problem. You are creating a CKEditor where the only config >> you have is {"scayt_autoStartup":false}. All other configurations >> (toolbar buttons, font-size, font-family, etc) are being ignored. > > I have spotted the issue - we should be telling ckeditor to use our > configuration array which is stored in the page in a javascript > variable. Fixed.
Attachment
Watch this ticket