Tickets :: Comment on [#9024] DIMP initialises IMP session

* Your Email Address
* Spam protection	Enter the letters below: . . __.. .. ..__ \|__\|(__ \ /\|_/ [__) \| \|.__) \/ \| \\|
Comment	> Accessing https://webmail.host/dimp/ without being logged in > redirects to Horde login screen. After logging in /dimp/index.php is > opened again but this time IMP session is missing. Another redirect > happens here, this time to /imp/redirect.php. Finally > /imp/redirect.php forwards to /imp/login.php with > logout_reason=failed. This final redirect happens here: > > /* If we already have a session: / > if (isset($_SESSION['imp']) && is_array($_SESSION['imp'])) { > / Make sure that if a username was specified, it is the current > * username. / > if (($imapuser !== null && ($imapuser != $_SESSION['imp']['user'])) \|\| > ($pass !== null && ($pass != > Secret::read(Secret::getKey('imp'), $_SESSION['imp']['pass'])))) { > > / Disable the old session. */ > unset($_SESSION['imp']); > _redirect(Auth::addLogoutParameters(IMP::logoutUrl(), > AUTH_REASON_FAILED)); > } > > Problem is that DIMP initializes $_SESSION['imp'] with > > $_SESSION['imp']['viewmode'] = 'dimp' > > but the rest of the session is missing so IMP thinks something went > wrong. Attached patch fixes this causing DIMP to update the session > only if it's already initialized.
Attachment
Watch this ticket