Tickets :: Comment on [#7934] smb driver's _command needs to be charset aware

* Your Email Address
* Spam protection	Enter the letters below: .__ .__ . .. .. . [__)[ __\|\ \|\|\/\|\ / \| \[_./\| \\|\| \| \/
Comment	>>>> That doesn't make any sense to me because > >>>> - we already set LC_ALL in horde > >> > >> That may be, but that environment is not passed to smbclient command > >> in _command(). > > > > This might be a problem with your system, if LC_ALL doesn't set > LC_CTYPE. Or are you saying that LC_ALL isn't set either? > > > >>>> - this only works with horde anyway, but this is a pear package. > >>>> please revert. > >>> > >>> Done. Although the 1st point seems irrelevant to me: if this is > >>> truly a PEAR package, then we necessarily have to set LC_* inside the > >>> driver because there are no guarantees that it will have been set > >>> elsewhere since Horde is not a pre-requisite. > >> > >> My testing showed that smbdriver might work correctly without this > >> patch, but only if host's default environment and the current locale > >> in gollem use the same charset. > > > > But the assumption that the files in the Samba backend have the same > locale like the current Horde frontend is completely wrong. If at > all, then we need to specify a charset per backend, and convert > to/from that.
Attachment
Watch this ticket