Tickets :: Comment on [#7675] Missing argument 7 for Whups

* Your Email Address
* Spam protection	Enter the letters below: \ /.__.. ..__ .__. >< \| \|\|\/\|[ __\| \| / \\|__\|\| \|[_./\|__\|
Comment	> maybe just a tweak, however PHP log reports > > > > "PHP Warning: Missing argument 7 for Whups_Driver::mail(), called in > /var/www/horde-3.3/whups-h3-1.0/lib/Whups.php on line 751 and defined > in /var/www/horde-3.3/whups-h3-1.0/lib/Driver.php on line 335" > > > > lib/Whups.php:751 > > $whups_driver->mail(null, $user, $subject, $email, $user, true); > > > > it could be ok to put a default for "$queue_id" in Whups_Driver::mail(); e.g. > > > > function mail($ticket_id, $recipients, $subject, $message, $from, > > $reminder, $queue_id = null, $is_new = false) > > > > later in the function, we can check the "$queue_id" value instead of > using it directly; e.g.: > > > > if (!is_null($queue_id)) { > > $queue = $this->getQueue($queue_id); > > } else { > > ... > >
Attachment
Watch this ticket