Tickets :: Comment on [#7529] uncatched failed prepare statements in convert_datatree_shares_to

* Your Email Address
* Spam protection	Enter the letters below: . . __ .___. .. . \| \|/ `[__ \|\ \|\ / \|__\|\__.[___\| \\| \/
Comment	> All convert_datatree_shares_to_sql scripts don't catch failed prepare > statements, > > which may lead to an inconsistent database and cause a fatal php error, > > trying to call the non existing function "execute" on a MDB2_Error object. > > > > This is a patch for > > It catches the failed prepare statement on write sql statements > (INSERT and DELETE) > > and encapsulate them in a transaction to rollback on error. This is > to keep the > > database in an consistent state and to allow to rerun the script on > errors with out > > loosing or dublicating any shares. This patch also returns more > informations as > > "Unkown Error" is not a very usefull. > > > > The following problems are still open as i did not need them to solve for me. > > > > - This patch requieres the database to support transactions. I don't know if > > Horde supports any database that don't support transactions, but it should > > be cecked. > > > > - This patch does not catch failed prepare statements on SELECT statements. > > This may result in the same fatal error. > > > > > >
Attachment
Watch this ticket