Tickets :: Comment on [#7050] httpd segfaults with sidebar.php

* Your Email Address
* Spam protection	Enter the letters below: .__..__.. ..__ . . [__]\| \|\|__\|[__)\| \| \| \|\|__\\| \|\| \|/\\|
Comment	>> Michael, looks like you did the commit in question > >> (http://cvs.horde.org/diff.php/imp/lib/Block/tree_folders.php?r1=1.69&r2=1.70) - do you remember what this >> was > >> for? > > > > Well... besides the fact that without that code no mailboxes show > up, it's kind of just a little bit important. > > > > I don't see anything wrong with that code. We want to show mailboxes > in the bottom level of the namespace (when $val['level'] is empty) > directly under the 'imp' entry (which is what $parent should be). > However, we can't directly use "$parent . $val['parent']" as the > parent ID in this case because $val['parent'] is equal to > IMPTREE_BASE_ELT -- which is '%'. The parent entry "imp%" does not > exist, obviously, so none of these folders (nor any of its children) > will ever show up. > > > > IMPTREE_BASE_ELT used to be equal to \01 I belive which would allowed > this code to work before 6/07. For various reasons, using \01 to > stand for the base was not a good idea, so thus the need to catch the > space 'base level' case.
Attachment
Watch this ticket