Tickets :: Comment on [#6625] imp/lib/SpellChecker/aspell.php test for ecode broken

* Your Email Address
* Spam protection	Enter the letters below: . ,. __.. .. \./ \| (__ \ /\| \| \|___.__) \/ \|___
Comment	> per http://marc.info/?l=imp&m=120853832309748&w=2 > > > > I think I've tracked the issue down. IMP is looking for aspell to > exit with a code of "0" to decide whether the spellcheck works. > > > > imp/lib/SpellChecker/aspell.php ~ ln 67: > > > > if (($ecode = proc_close($process)) != 0) { > > require_once 'PEAR.php'; > > if ($this->_encoding) { > > $err = String::convertCharset($err, $this->_encoding, > $charset); > > } > > return PEAR::raiseError('spellcheck failed: ' . $err, $ecode); > > } > > > > proc_close() doesn't return results you think it's returning. See... > > http://us2.php.net/manual/en/function.proc-close.php > > http://bugs.php.net/bug.php?id=17538 > > > > Apparently, it's especially faulty if you compiled php with > --enable-sigchild, which you're told to do if you're trying to use > oracle on linux. > > > > The debugging stubs I placed in aspell.php clearly show that aspell > is being invoked, and is returning the expected output. If I change.. > > > > proc_close($process)) != 0 > > > > to look for -1, spellchecking works just dandy. > >
Attachment
Watch this ticket