Tickets :: Comment on [#6560] admin/setup/config.php doesn't trap invalid applicatione

* Your Email Address
* Spam protection	Enter the letters below: . .._.. . __ .__ \|\/\| \| \|\/\|/ `[__) \| \|_\|_\| \|\__.\| \
Comment	> In admin/setup/config.php:29-39, there is: > > $app = Util::getFormData('app'); > > $appname = $registry->get('name', $app); > > $title = sprintf(_("%s Setup"), $appname); > > > > if ($app === null && > > in_array($app, $registry->listApps(array('inactive', 'hidden', > 'notoolbar', 'active', 'admin')))) { > > $notification->push(_("Invalid application."), 'horde.error'); > > $url = Horde::applicationUrl('admin/setup/index.php', true); > > header('Location: ' . $url); > > exit; > > } > > > > The logic doesn't capture invalid applications correctly: the logic > says throw an invalid application error when not given an app and > "null" is a listed application. In the field, if you manually alter > the app GET line variable to something non-existent, you get the > horde application setup, instead of the invalid application error. > > > > I believe the logic should be throw an invalid application error when > not given an app or the app is not a listed application. Patch > attached.
Attachment
Watch this ticket