Tickets :: Comment on [#6424] Possible bug in lib/Horde/MIME/Structure.php

* Your Email Address
* Spam protection	Enter the letters below: . ..__.. .._..__ \|\/\|\| \|\|_/ \| [__) \| \|\|__\|\| \_\|_[__)
Comment	> I noticed that we have problem with mails without content-type > headers and 8bit characters. > > I know that these are not allowed in standards. > > We have configured horde/imp to force to use iso-8859-1 for mails > without charset. (with > > default_msg_charset in imp/config/prefs.php.) > > > > Even with default charset, mails without charset doesn't show accent > chars right. I notised that our imap server gives those mails charset > as 'US-ASCII' and horde checks charset as 'us-acii' (lowercase), and > does not set it to default charser. I changes test to 'US-ASCII', and > broken mails shows ok now. > > > > So i think that test should uppercase charset first, and then > compare. Here is patch for that: > > > > > > --- ../horde-webmail-1.0.1/lib/Horde/MIME/Structure.php 2007-03-16 > 21:24:26.000000000 +0200 > > +++ lib/Horde/MIME/Structure.php 2008-03-11 14:33:48.000000000 +0200 > > @@ -161,7 +161,7 @@ > > > > /* Set the default character set. */ > > if (($ob->getPrimaryType() == 'text') && > > - ($ob->getCharset() == 'us-ascii') && > > + (String::upper($ob->getCharset()) == 'US-ASCII') && > > isset($GLOBALS['mime_structure']['default_charset'])) { > > $ob->setCharset($GLOBALS['mime_structure']['default_charset']); > > } > >
Attachment
Watch this ticket