Tickets :: Comment on [#606] Typecasting required in whups/lib/Driver/sql.php on Oracle

* Your Email Address
* Spam protection	Enter the letters below: .__ . .._. __..__. \| \\|_/ \| (__ [__] \|__/\| \_\|_.__)\| \|
Comment	> Attempt to fetch comments, file whups/lib/Driver/sql.php,v 1.195, > > function _getHistory(). > > The JOINs fail on Oracle, for example line 823: > > > > $join .= 'LEFT JOIN whups_queues ON whups_logs.log_type = \'queue\' > AND whups_logs.log_value = whups_queues.queue_id '; > > > > The clause whups_logs.log_value = whups_queues.queue_id causes an > error ORA-017222: invalid number because whups_queues.queue_id is > NUMBER, whups_logs.log_value is VARCHAR and contains non-numeric > values (comments itself). So implicit type conversion is failed. > > Suggest explicit portable typecasting for NUMBER fields in all JOINs, > something like this: > > > > $join .= 'LEFT JOIN whups_queues ON whups_logs.log_type = \'queue\' > AND whups_logs.log_value = cast(whups_queues.queue_id as character) '; > >
Attachment
Watch this ticket