6.0.0-beta1
▾
Tasks
New Task
Search
Photos
Wiki
▾
Tickets
New Ticket
Search
dev.horde.org
Toggle Alerts Log
Help
10/18/25
H
istory
A
ttachments
C
omment
W
atch
Download
Comment on [#5843] spam-filtering for maildrop
*
Your Email Address
*
Spam protection
Enter the letters below:
.___.._..__ .__ .__ | | [__)[ __[__) | _|_| \[_./[__)
Comment
>>> Thanks for catching that. I've taken another shot at it based on your > >>> example. Can you please check: > >>> http://cvs.horde.org/diff.php/ingo/lib/Script/maildrop.php?r1=1.17&r2=1.18&ty=u > >>> > >>> Thanks! > >> > >> Looks much better, but it still won't work, if the conditions are > >> joined by OR. I'll take a shot at it these days, some of the > >> refactoring I've planned to do sometime... Hang on ;) If it's urgent, > >> I'm sure we can find a fix without the restructuring. > > > > I'm sorry, I just learned that && has a higher precedence than ||, so > your code should work fine even if conditions are joined by OR. > > > > However the 'not equal' test should use != as operator, instead of > > ! /Header:.../ && $MATCH1 == condition, > > because that would indeed not work. Furthermore, 'not equal' must > then be excluded from the negation above (line 557 in HEAD). Patch > attached. > > > > PS: The patch also removes some duplicated code by defining the > numerical relation operators in an instance variable. Remove this if > you don't find it appropriate.
Attachment
Watch this ticket
N
ew Ticket
M
y Tickets
S
earch
Q
uery Builder
R
eports
Saved Queries
Open Bugs
Bugs waiting for Feedback
Open Bugs in Releases
Open Enhancements
Enhancements waiting for Feedback
Bugs with Patches
Enhancements with Patches
Release Showstoppers
Stalled Tickets
New Tickets
Horde 5 Showstoppers