Tickets :: Comment on [#5595] Javascript error in templates/prefs/identityselect.inc (Firefox 2.0.0.5)

* Your Email Address
* Spam protection	Enter the letters below: .___. ..___\ /.__ [__ \|\/\|[__ >< [__) \| \| \|\| / \[__)
Comment	> I have disabled some of the fields in IMP's personal information > options, for example the sender address field. Personal information > is divided into multiple identities, one of which is chosen and then > javascript populates the appropriate fields. When populating the > fields, the script loops over the identity array, changing the values > of the fields one by one. However, when I have some of the fields > disabled and thus non-existent, a javascript error occurs (at least > on Firefox 2.0.0.5, haven't tested other browsers) when trying to > change the value of a non-existent field and the rest of the fields > remain untouched as the browser won't continue to run the javascript. > > > > I solved this with a simple one-liner; just check to see if the field > actually exists before trying to mangle with it. If it doesn't, just > skip to the next. Patch attached.
Attachment
Watch this ticket