Tickets :: Comment on [#5207] Make the deliverables billable/non-billable

* Your Email Address
* Spam protection	Enter the letters below: .__.. . ,. .. . [__]\| \./ \|__\|\ / \| \|\|___ \| \| \| \/
Comment	> Much better, thanks. There are still a few nits, sorry for being picky: > > - The sql upgrade script is for mysql. Please see > docs/CODING_STANDARDS for preferred sql syntax, and other upgrade > scripts for examples. > > - The default value of a "boolean" field type is already "false", no > need to explicitly specify that. > > - Use "empty($var)" instead of "$var == false" especially for > configuration values. > > - Add the end of the patch to Driver/sql.php you casted the rate to > int and the billable flag to float, it should be the opposite.
Attachment
Watch this ticket