Tickets :: Comment on [#4991] Default identity not selected correctly when replying to or forwarding messages in Inbox

* Your Email Address
* Spam protection	Enter the letters below: ..__ . .. ,. . \|[__)\|__\| \./ \|_/ \__\|\| \| \| \| \| \
Comment	>> First of all, this has to be implemented in getMatchingIdentity(). > >> And there is the possibility that the from_addr is locked, but the > >> user still has two different from addresses. The correct logic would > >> be to not stop when the first matching identity is found, but to find > >> all of them, and then select the default identity or the first one > >> from this list. > > > > From what I can see once the from_addr pref is locked and the value > is '' , getMatchingIdentity() always just returns one value, > $imp['user']@$imp['maildomain'] . That is because of the > getFromAddress function below, in particular this bit: > > > > $val = $this->getValue('from_addr', $ident); > > if (empty($val)) { > > $val = $imp['user']; > > } > > > > I have tested by creating 4 identities with 4 different from_addr . > As soon as I lock from_addr as false with a value of '' , those > from_addr in horde_prefs are ignored. > > > > > > > > function getFromAddress($ident = null) > > { > > global $imp; > > > > if (!empty($this->_fromList[$ident])) { > > return $this->_fromList[$ident]; > > } > > > > $val = $this->getValue('from_addr', $ident); > > if (empty($val)) { > > $val = $imp['user']; > > } > > > > if (!strstr($val, '@')) { > > $val .= '@' . $imp['maildomain']; > > } > > > > $this->_fromList[$ident] = $val; > > > > return $val; > > } > >
Attachment
Watch this ticket