Tickets :: Comment on [#4938] Sponsored bounty for timed vacation messages

* Your Email Address
* Spam protection	Enter the letters below: .___..___.. .. ,.__ \| \| \| \| \./ [__) \| \| \|/\\| \| [__)
Comment	> I'm ready to commit this patch if it's cleaned up a bit. First, > please have a look through horde/docs/CODING_STANDARDS. Second, you > can use Horde_Form much better in a few places - for instance, it'd > be much nicer to have a Horde_Date object for the start/end times, > and to set it with a monthdayyear Horde_Form type (with a pop-up date > picker), rather than the multiple accessors for year/month/day you > currently have. > > > > - you should use $form->getInfo() so that you're not accessing $vars > directly to get the submitted values > > > > - use PHP features, like using strtotime('-1 day') rather than > subtracting a fixed number of seconds from time(). Also on that line > you can do $start = $end = ... > > > > - no need to assign the result of $form->addVariable(...) to a > variable unless you're actually going to do something with it. > > > > There might be a few other things but that should be most of it. Thanks!
Attachment
Watch this ticket